-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update layouts/BaseLayout tests to Vitest #3208
Merged
nicholas-codecov
merged 47 commits into
main
from
chore-vitest-update-base-layout-tests
Sep 19, 2024
Merged
Changes from 46 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
b766325
add in vitest
nicholas-codecov 8a1c7b1
rename old_ui tests from spec to test for vitest
nicholas-codecov 627b145
add in data-testid to icon
nicholas-codecov dc8fe8d
temp
nicholas-codecov 3f154bb
ignore test test files in craco
nicholas-codecov 71f0a33
add in coverage stuff for vitest
nicholas-codecov b08164b
setup CI to run vitest tests
nicholas-codecov 7b06a1e
whoops didn't mean to commit these
nicholas-codecov b572a9d
add names to test runner indexes
nicholas-codecov ce0b6e5
set min threads
nicholas-codecov bb488b9
add in reporter all tests
nicholas-codecov 950d6ac
conditionally enable junit test reporter
nicholas-codecov 64c2939
only include src files in coverage reporting
nicholas-codecov 9917c18
exclude some files from coverage reporting
nicholas-codecov cab1973
there are some issues with coverage excludes making the files not acc…
nicholas-codecov f5b6466
forgot that I moved the setup file to ts
nicholas-codecov d2bd52b
add --changed to test watch command
nicholas-codecov d120380
add name to prod uploads for craco and vitest
nicholas-codecov fc5eb5b
tidying up some stuff in the ci
nicholas-codecov 168ffa4
disable vitest to see what happens
nicholas-codecov 619bbac
increase n builds
nicholas-codecov 84d1276
remove generating icons for webpack
nicholas-codecov 3d6ef25
update ci command
nicholas-codecov 71f0955
rename to .jsx because it contains jsx
nicholas-codecov 53616b2
swap from v8 to istanbul for coverage reporting
nicholas-codecov d188c3e
only generate icons for vite, and craco build
nicholas-codecov 2a1068d
small tweaks to the codecov yml config
nicholas-codecov 976ade0
generate webpack icons before running tests
nicholas-codecov 0a5ed38
styling tweaks to vitest
nicholas-codecov e53de7e
small tweaks to vitest config
nicholas-codecov 19b463e
add in msw 2
nicholas-codecov 634a18b
add in examples so our test split function doesn't complain
nicholas-codecov 6e656c5
add in all test file extensions
nicholas-codecov 52fd40c
remove left over log
nicholas-codecov 31b1335
tweak excludes
nicholas-codecov 850a7a8
disable this eslint rule as it seems we need to do the manual cleanup
nicholas-codecov d8c6af2
make sure TS knows about the vi types globally
nicholas-codecov 79f70a0
sort out vitest with setup stuff as well as loading correct envs
nicholas-codecov 9f73de4
resolve issue with vitest types interferring with craco stuff
nicholas-codecov 1c2aebc
tweak reporters
nicholas-codecov 5d6b24e
remove test files from coverage reporting
nicholas-codecov bc5a324
update BaseLayout test
nicholas-codecov 7317a5e
update useUserAccessGate tests
nicholas-codecov cff7486
update InstallationHelpBanner tests
nicholas-codecov 532ffce
update index files from js to ts
nicholas-codecov e25f145
Merge branch 'main' into chore-vitest-update-base-layout-tests
nicholas-codecov 61c44ef
remove status 200 as it's the default
nicholas-codecov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In App.test.tsx you added
{ status: 200 }
as an example of setting status which I'm cool with, but since 200 is default, IMO we shouldn't make explicitly stating it a pattern across the codebase. Thoughts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea we can remove these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tyty appreciate