Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update layouts/ToastNotifications to Vitest #3217

Merged
merged 5 commits into from
Sep 20, 2024
Merged

chore: Update layouts/ToastNotifications to Vitest #3217

merged 5 commits into from
Sep 20, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

Update tests in layouts/ToastNotifications to Vitest

Notable Changes

  • Update index file to TS
  • Update ToastNotifications tests to Vitest

@codecov-staging
Copy link

Bundle Report

Bundle size has no change ✅

Bundle name Size Change
gazebo-staging-array-push 6.0MB 0 bytes

@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024

Bundle Report

Bundle size has no change ✅

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Sep 19, 2024 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
f723953 Thu, 19 Sep 2024 17:14:04 GMT Expired Expired
ac91eef Fri, 20 Sep 2024 11:09:41 GMT Expired Expired
e82c7f8 Fri, 20 Sep 2024 17:35:28 GMT Expired Expired
de91781 Fri, 20 Sep 2024 18:28:01 GMT Cloud Enterprise

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3217   +/-   ##
=======================================
  Coverage   99.06%   99.06%           
=======================================
  Files         798      798           
  Lines       13966    13966           
  Branches     3879     3958   +79     
=======================================
  Hits        13836    13836           
  Misses        122      122           
  Partials        8        8
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.51% <ø> (ø)
Pages 98.89% <ø> (ø)
Services 99.41% <ø> (ø)
Shared 99.58% <ø> (ø)
UI 99.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e82ef28...de91781. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (e82ef28) to head (de91781).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3217   +/-   ##
=======================================
  Coverage   99.06%   99.06%           
=======================================
  Files         798      798           
  Lines       13966    13966           
  Branches     3879     3963   +84     
=======================================
  Hits        13836    13836           
  Misses        122      122           
  Partials        8        8
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.51% <ø> (ø)
Pages 98.89% <ø> (ø)
Services 99.41% <ø> (ø)
Shared 99.58% <ø> (ø)
UI 99.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e82ef28...de91781. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (e82ef28) to head (de91781).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3217   +/-   ##
=======================================
  Coverage   99.06%   99.06%           
=======================================
  Files         798      798           
  Lines       13966    13966           
  Branches     3958     3932   -26     
=======================================
  Hits        13836    13836           
  Misses        122      122           
  Partials        8        8
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.51% <ø> (ø)
Pages 98.89% <ø> (ø)
Services 99.41% <ø> (ø)
Shared 99.58% <ø> (ø)
UI 99.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e82ef28...de91781. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (e82ef28) to head (de91781).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #3217   +/-   ##
===========================================
  Coverage   99.06000   99.06000           
===========================================
  Files           798        798           
  Lines         13966      13966           
  Branches       3879       3963   +84     
===========================================
  Hits          13836      13836           
  Misses          122        122           
  Partials          8          8
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 98.51% <ø> (ø)
Pages 98.89% <ø> (ø)
Services 99.41% <ø> (ø)
Shared 99.58% <ø> (ø)
UI 99.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e82ef28...de91781. Read the comment docs.

ajay-sentry
ajay-sentry reviewed Sep 20, 2024
View reviewed changes
src/layouts/ToastNotifications/ToastNotifications.test.jsx
@@ -35,7 +36,7 @@ describe('ToastNotifications', () => {

describe('when rendered', () => {
beforeEach(() => {
jest.useFakeTimers()
vi.useFakeTimers()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice that there's a plug and play equivalent to the timers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's amazing how well they've done it

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 0acf455 Sep 20, 2024
64 checks passed
@nicholas-codecov nicholas-codecov deleted the chore-update-layouts-toast-nofitications-to-vitest branch September 20, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajay-sentry ajay-sentry ajay-sentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholas-codecov @codecov-releaser @ajay-sentry