Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update layouts/ToastNotifications to Vitest #3217

Merged
merged 5 commits into from
Sep 20, 2024
Merged

chore: Update layouts/ToastNotifications to Vitest #3217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c95cf3
update index file from JS to TS
nicholas-codecov Sep 19, 2024
f723953
update ToastNofitications tests to vitest
nicholas-codecov Sep 19, 2024
ac91eef
remove manual cleanup
nicholas-codecov Sep 20, 2024
e82c7f8
Merge branch 'main' into chore-update-layouts-toast-nofitications-to-…
nicholas-codecov Sep 20, 2024
de91781
Merge branch 'main' into chore-update-layouts-toast-nofitications-to-…
nicholas-codecov Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...Notifications/ToastNotifications.spec.jsx → ...Notifications/ToastNotifications.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { render, screen } from '@testing-library/react'
import { vi } from 'vitest'

import {
useNotifications,
Expand All @@ -22,10 +23,10 @@ const notifications = [
},
]

jest.mock('services/toastNotification')
vi.mock('services/toastNotification')

describe('ToastNotifications', () => {
const removeNotification = jest.fn()
const removeNotification = vi.fn()

function setup() {
useNotifications.mockReturnValue(notifications)
Expand All @@ -35,7 +36,7 @@ describe('ToastNotifications', () => {

describe('when rendered', () => {
beforeEach(() => {
jest.useFakeTimers()
vi.useFakeTimers()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice that there's a plug and play equivalent to the timers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's amazing how well they've done it

removeNotification.mockReset()
setup()
})
Expand All @@ -47,7 +48,7 @@ describe('ToastNotifications', () => {

describe('when enough time passes', () => {
beforeEach(() => {
jest.runOnlyPendingTimers()
vi.runOnlyPendingTimers()
})

it('calls removeNotification with the notification that disappear', () => {
Expand Down
0 src/layouts/ToastNotifications/index.js → src/layouts/ToastNotifications/index.ts
View file
Open in desktop
File renamed without changes.
Loading