Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: refactor page components into separate sections #3231

Merged

refactor components into separate sections, write a simple test for page

60a2cf8
Select commit
Loading
Failed to load commit list.
Merged

ref: refactor page components into separate sections #3231

refactor components into separate sections, write a simple test for page
60a2cf8
Select commit
Loading
Failed to load commit list.
Codecov Notifications / codecov/project succeeded Sep 20, 2024 in 1s

97.88% (+0.16%) compared to 555e411

View this Pull Request on Codecov

97.88% (+0.16%) compared to 555e411

Details

Codecov Report

Attention: Patch coverage is 3.12500% with 31 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
...ailedTestsPage/SelectorSection/SelectorSection.tsx 0.00% 24 Missing ⚠️
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 12.50% 7 Missing ⚠️

Impacted file tree graph

@@                  Coverage Diff                   @@
##           tests-analytics-v2    #3231      +/-   ##
======================================================
+ Coverage               97.72%   97.88%   +0.16%     
======================================================
  Files                     931      935       +4     
  Lines                   14522    14538      +16     
  Branches                 3969     3969              
======================================================
+ Hits                    14192    14231      +39     
+ Misses                    322      302      -20     
+ Partials                    8        5       -3     
Files Coverage Δ
...FailedTestsTab/FailedTestsPage/FailedTestsPage.tsx 100.00% <ø> (+100.00%) ⬆️
.../SelectorSection/BranchSelector/BranchSelector.tsx 100.00% <ø> (ø)
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 40.00% <12.50%> (-12.95%) ⬇️
...ailedTestsPage/SelectorSection/SelectorSection.tsx 0.00% <0.00%> (ø)

... and 21 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (-0.18%) ⬇️
Layouts 98.87% <ø> (+1.49%) ⬆️
Pages 98.41% <3.12%> (+0.06%) ⬆️
Services 99.44% <ø> (+0.03%) ⬆️
Shared 99.65% <ø> (+0.06%) ⬆️
UI 94.57% <ø> (+0.53%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 555e411...60a2cf8. Read the comment docs.