Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongqui
approved these changes
Jan 9, 2025
| @@ -0,0 +1,168 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="ko"> | |||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <link rel="stylesheet" href="src/assets/css/style.css" /> |
| <span class="blind">판다마켓</span> | ||
| </a> | ||
| </h1> | ||
| <button> |
There was a problem hiding this comment.
상호작용이 가능한 요소(button, a, input...)를 중첩하는것은 표준에 맞지 않습니다!
button, a 태그 둘 중에 하나만 써주세요~!
| margin: 0 auto; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: space-between; |
| </head> | ||
| <body> | ||
| <div id="wrap"> | ||
| <header id="header" class="header"> |
| </header> | ||
| <div class="main-kv"> | ||
| <div class="main-kv__wrap"> | ||
| <div class="main-kv__contents"> |
There was a problem hiding this comment.
클래스명을 짜임새 있게 잘 구성해주신 것 너무 좋습니다 👍
| } | ||
|
|
||
| /* 미디어 쿼리 */ | ||
| @media screen and (max-width: 1366px) { |
| <div class="main-kv"> | ||
| <div class="main-kv__wrap"> | ||
| <div class="main-kv__contents"> | ||
| <h2> |
There was a problem hiding this comment.
크게 상관은 없지만 패딩 때문에 h2가 불필요하게 커진 거 같네요! 패딩은 보통 요소의 내부 간격 위해 쓰이고, 위치를 옮기기엔 부적절해 보입니다!
|
감사합니다 부족한 부분은 참고해서 공부해 보겠습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게