[김성빈] Sprint1 #9
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>faq</title> | ||
| </head> | ||
| <body> | ||
| <div>faq</div> | ||
| </body> | ||
| </html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,168 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="ko"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <link rel="stylesheet" href="src/assets/css/style.css" /> | ||
|
|
||
| <link rel="stylesheet" href="src/assets/css/font.css" /> | ||
| <title>판다마켓</title> | ||
| </head> | ||
| <body> | ||
| <div id="wrap"> | ||
| <header id="header" class="header"> | ||
|
|
||
| <div class="header__wrap"> | ||
| <h1> | ||
| <a href="/" class="logo"> | ||
| <span class="blind">판다마켓</span> | ||
| </a> | ||
| </h1> | ||
| <button> | ||
|
There was a problem hiding this comment. 상호작용이 가능한 요소(button, a, input...)를 중첩하는것은 표준에 맞지 않습니다! button, a 태그 둘 중에 하나만 써주세요~! |
||
| <a href="/login.html" class="btn btn--login"> | ||
| <span>로그인</span> | ||
| </a> | ||
| </button> | ||
| </div> | ||
| </header> | ||
| <div class="main-kv"> | ||
| <div class="main-kv__wrap"> | ||
| <div class="main-kv__contents"> | ||
|
There was a problem hiding this comment. 클래스명을 짜임새 있게 잘 구성해주신 것 너무 좋습니다 👍 |
||
| <h2> | ||
|
There was a problem hiding this comment. 크게 상관은 없지만 패딩 때문에 h2가 불필요하게 커진 거 같네요! 패딩은 보통 요소의 내부 간격 위해 쓰이고, 위치를 옮기기엔 부적절해 보입니다! |
||
| 일상의 모든 물건을<br class="mov2" /> | ||
| 거래해 보세요 | ||
| </h2> | ||
| <button class="main-kv__button"> | ||
| <a href="/items.html" class="btn btn--kv"> | ||
| <span>구경하러 가기</span> | ||
| </a> | ||
| </button> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| <div class="container"> | ||
| <section class="main-section"> | ||
| <div class="main-section__inner"> | ||
| <div class="main-section__left main-section__left--image"> | ||
| <div class="main-section__image"> | ||
| <img | ||
| src="src/assets/image/market_img01.jpg" | ||
| alt="인기 상품을 확인해 보세요" | ||
| /> | ||
| </div> | ||
| </div> | ||
| <div class="main-section__right"> | ||
| <span class="main-section__category">Hot item</span> | ||
| <h3 class="main-section__title"> | ||
| 인기 상품을<br class="mov" />확인해 보세요 | ||
| </h3> | ||
| <p class="main-section__description"> | ||
| 가장 HOT한 중고거래 물품을<br /> | ||
| 판다 마켓에서 확인해 보세요 | ||
| </p> | ||
| </div> | ||
| </div> | ||
| </section> | ||
| <section class="main-section"> | ||
| <div class="main-section__inner main-section__inner--reverse"> | ||
| <div class="main-section__left tar"> | ||
| <span class="main-section__category">Search</span> | ||
| <h3 class="main-section__title"> | ||
| 구매를 원하는<br class="mov" /> | ||
| 상품을 검색하세요 | ||
| </h3> | ||
| <p class="main-section__description"> | ||
| 구매하고 싶은 물품은 검색해서<br />쉽게 찾아보세요 | ||
| </p> | ||
| </div> | ||
| <div class="main-section__right main-section__right--image"> | ||
| <div class="main-section__image"> | ||
| <img | ||
| src="src/assets/image/market_img02.jpg" | ||
| alt="구매를 원하는 상품을 검색하세요" | ||
| /> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </section> | ||
| <section class="main-section"> | ||
| <div class="main-section__inner"> | ||
| <div class="main-section__left main-section__left--image"> | ||
| <div class="main-section__image"> | ||
| <img | ||
| src="src/assets/image/market_img03.jpg" | ||
| alt="판매를 원하는 상품을 등록하세요" | ||
| /> | ||
| </div> | ||
| </div> | ||
| <div class="main-section__right"> | ||
| <span class="main-section__category">Register</span> | ||
| <h3 class="main-section__title"> | ||
| 판매를 원하는<br class="mov" />상품을 등록하세요 | ||
| </h3> | ||
| <p class="main-section__description"> | ||
| 어떤 물건이든 판매하고 싶은 상품을<br />쉽게 등록하세요 | ||
| </p> | ||
| </div> | ||
| </div> | ||
| </section> | ||
| <div class="main-banner"> | ||
| <div class="main-banner__inner"> | ||
| <h2>믿을 수 있는<br />판다마켓 중고 거래</h2> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| <footer class="footer"> | ||
| <div class="footer__inner"> | ||
| <div class="footer__top"> | ||
| <span>©codeit - 2024</span> | ||
| <ul class="person"> | ||
| <li> | ||
| <a href="/privacy.html">Privacy Policy</a> | ||
| </li> | ||
| <li> | ||
| <a href="/faq.html">FAQ</a> | ||
| </li> | ||
| </ul> | ||
| <ul class="sns"> | ||
| <li> | ||
| <a | ||
| href="https://www.facebook.com" | ||
| class="icon icon--facebook" | ||
| target="_blank" | ||
| > | ||
| <span class="blind">페이스북</span> | ||
| </a> | ||
| </li> | ||
| <li> | ||
| <a | ||
| href="https://www.twitter.com" | ||
| class="icon icon--twitter" | ||
| target="_blank" | ||
| > | ||
| <span class="blind">트위터</span> | ||
| </a> | ||
| </li> | ||
| <li> | ||
| <a | ||
| href="https://www.youtube.com" | ||
| class="icon icon--youtube" | ||
| target="_blank" | ||
| > | ||
| <span class="blind">유튜브</span> | ||
| </a> | ||
| </li> | ||
| <li> | ||
| <a | ||
| href="https://www.instagram.com" | ||
| class="icon icon--instagram" | ||
| target="_blank" | ||
| > | ||
| <span class="blind">인스타그램</span> | ||
| </a> | ||
| </li> | ||
| </ul> | ||
| </div> | ||
| </div> | ||
| </footer> | ||
| </div> | ||
| </body> | ||
| </html> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>items</title> | ||
| </head> | ||
| <body> | ||
| <div>items</div> | ||
| </body> | ||
| </html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>login</title> | ||
| </head> | ||
| <body> | ||
| <div>login</div> | ||
| </body> | ||
| </html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>privacy</title> | ||
| </head> | ||
| <body> | ||
| <div>privacy</div> | ||
| </body> | ||
| </html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| @font-face { | ||
| font-family: "Pretendard-Regular"; | ||
| src: url("https://fastly.jsdelivr.net/gh/Project-Noonnu/noonfonts_2107@1.1/Pretendard-Regular.woff") | ||
| format("woff"); | ||
| font-weight: 400; | ||
| font-style: normal; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lang을 잘 챙겨주셨네요! 👍