Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split constraints file by purpose #24

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Split constraints file by purpose #24

merged 1 commit into from
Mar 7, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Feb 26, 2024

For clarity, keep pins which are intended to allow CI jobs to target the HEADs of "internal" dependencies from external "pins".

@cottsay cottsay added the enhancement New feature or request label Feb 26, 2024
@cottsay cottsay self-assigned this Feb 26, 2024
@cottsay
Copy link
Member Author

cottsay commented Mar 1, 2024

Note that we dropped the only pin for colcon recently so the constraints-pins.txt file is currently empty.

nuclearsandwich
nuclearsandwich requested changes Mar 2, 2024
View reviewed changes
Copy link

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the shell script is now missing the unpinning of the current package. Or I'm a poor shell interpreter on a Saturday morning.

action.yaml Outdated Show resolved Hide resolved
@cottsay cottsay mentioned this pull request Mar 2, 2024
Merged
@cottsay
Split constraints file by purpose
5ce9d5a 
For clarity, keep pins which are intended to allow CI jobs to target the
HEADs of "internal" dependencies from external "pins".
@cottsay cottsay marked this pull request as ready for review March 5, 2024 15:37
@cottsay cottsay merged commit 69d9aa0 into main Mar 7, 2024
20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cottsay/split-constraints branch March 7, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

Assignees

@cottsay cottsay

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cottsay @nuclearsandwich