Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from pkg_resources to packaging for version comparison #560

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Switch from pkg_resources to packaging for version comparison #560

merged 1 commit into from
Jul 11, 2023

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Jul 5, 2023

Part of #552

@cottsay cottsay force-pushed the cottsay/packaging-version branch 2 times, most recently from 4c93ade to dad62fe Compare July 5, 2023 22:52
@codecov
Copy link

codecov bot commented Jul 5, 2023 •
edited
Loading

Codecov Report

Patch coverage: 29.41% and project coverage change: -0.14 ⚠️

Comparison is base (bed6cee) 82.01% compared to head (7e65e5f) 81.88%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #560      +/-   ##
==========================================
- Coverage   82.01%   81.88%   -0.14%     
==========================================
  Files          62       62              
  Lines        3642     3648       +6     
  Branches      705      705              
==========================================
  Hits         2987     2987              
- Misses        603      609       +6     
  Partials       52       52
Impacted Files Coverage Δ
colcon_core/package_identification/python.py 62.90% <0.00%> (-6.74%) ⬇️
colcon_core/task/python/test/pytest.py 28.75% <33.33%> (ø)
colcon_core/plugin_system.py 98.68% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cottsay cottsay self-assigned this Jul 6, 2023
@cottsay cottsay merged commit 7b70e61 into master Jul 11, 2023
@delete-merged-branch delete-merged-branch bot deleted the cottsay/packaging-version branch July 11, 2023 19:33
@cottsay cottsay mentioned this pull request Sep 6, 2023
Merged
@cottsay cottsay added this to the 0.13.0 milestone Sep 22, 2023
@cottsay cottsay added the enhancement New feature or request label Sep 22, 2023
@cottsay cottsay mentioned this pull request Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

Assignees

@cottsay cottsay

Labels
enhancement New feature or request
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cottsay @nuclearsandwich