Fix modified logger in add_file_handler, add tests #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that the `logger` parameter was previously unused, and that the function just used `colcon_logger` directly. As it happens, the only use of `add_file_handler` passes `colcon_logger`, so the mistake had no effect. This fixes the bug and adds a simple test for that code.
nuclearsandwich
approved these changes
May 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #649 +/- ##
==========================================
+ Coverage 83.43% 83.49% +0.05%
==========================================
Files 66 66
Lines 3816 3816
Branches 745 745
==========================================
+ Hits 3184 3186 +2
+ Misses 555 554 -1
+ Partials 77 76 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the
loggerparameter was previously unused, and that the function just usedcolcon_loggerdirectly. As it happens, the only use ofadd_file_handlerpassescolcon_logger, so the mistake had no effect.This fixes the bug and adds a simple test for that code.