Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modified logger in add_file_handler, add tests #649

Merged
merged 2 commits into from
May 24, 2024
Merged

Fix modified logger in add_file_handler, add tests #649

merged 2 commits into from
May 24, 2024

Commits on May 24, 2024

  1. Fix modified logger in add_file_handler, add tests 

    It appears that the `logger` parameter was previously unused, and that
the function just used `colcon_logger` directly. As it happens, the only
use of `add_file_handler` passes `colcon_logger`, so the mistake had no
effect.

This fixes the bug and adds a simple test for that code.
    @cottsay
    cottsay committed May 24, 2024
    Configuration menu
    Copy the full SHA
    0802431 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into cottsay/logging-file

    @cottsay
    cottsay committed May 24, 2024
    Configuration menu
    Copy the full SHA
    5cdb6c0 View commit details
    Browse the repository at this point in the history