Memoized Tailwind config evaluation #6500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkrmendy
changed the title
#14659 Bundle Size — 57.74MiB (~+0.01%).df49f33(current) vs 916e8b9 master#14647(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #14659 |
Baseline #14647 |
|
|---|---|---|
 Initial JS |
40.74MiB(~+0.01%) |
40.74MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
17.97% |
17.95% |
| Chunks |
21 |
21 |
| Assets |
23 |
23 |
| Modules |
4113 |
4113 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.41% |
27.41% |
| Packages |
475 |
475 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #14659 |
Baseline #14647 |
|
|---|---|---|
| JS |
57.73MiB (~+0.01%) |
57.73MiB |
| HTML |
7.37KiB (-0.25%) |
7.39KiB |
Bundle analysis report Branch feature/tailwind-config-memo-get... Project dashboard
Generated by RelativeCI Documentation Report issue
gbalint
approved these changes
Oct 9, 2024
This reverts commit e43a26c.
balazsbajorics
approved these changes
Oct 9, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
## Problem The Tailwind config is only accessible inside `useTailwindCompilation`, which means that the upcoming element style plugins won't be able to access it ## Fix Store the last seen text contents of the Tailwind config file along with the last evaluation result. If the new contents of the Tailwind config file are the same as the last seen contents, the last evaluation result, otherwise, re-evaluate the Tailwind config file, and store it, and return it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Tailwind config is only accessible inside
useTailwindCompilation, which means that the upcoming element style plugins won't be able to access itFix
Store the last seen text contents of the Tailwind config file along with the last evaluation result. If the new contents of the Tailwind config file are the same as the last seen contents, the last evaluation result, otherwise, re-evaluate the Tailwind config file, and store it, and return it