Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify solver imports explicitly #12

Merged
merged 6 commits into from
Oct 5, 2023
Merged

Conversation

lixitrixi
Copy link
Contributor

No description provided.

@lixitrixi lixitrixi mentioned this pull request Oct 4, 2023
@ozgurakgun
Copy link
Contributor

ozgurakgun commented Oct 4, 2023

github actions are not triggered on this, since the PR doesn't modify any files stored at the relevant paths. makes me think we should list Cargo.toml and Cargo.lock in the paths section of all 3 tests, since it would be good to trigger them when these files change. does that make sense?

@lixitrixi
Copy link
Contributor Author

github actions are not triggered on this, since the PR doesn't modify any files stored at the relevant paths. makes me think we should list Cargo.toml and Cargo.lock in the paths section of all 3 tests, since it would be good to trigger them when these files change. does that make sense?

Heard!

Should it be a separate PR?

@ozgurakgun
Copy link
Contributor

ozgurakgun commented Oct 4, 2023

I am not fussed, let's add onto this one.

@lixitrixi
Copy link
Contributor Author

@ozgurakgun This should be good to go now

@ozgurakgun ozgurakgun merged commit 27a39e5 into conjure-cp:main Oct 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants