Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Label the base build stage #36

Merged
1 commit merged into from
Apr 25, 2024
Merged

build: Label the base build stage #36

1 commit merged into from
Apr 25, 2024

Conversation

Eta0
Copy link
Collaborator

@Eta0 Eta0 commented Apr 8, 2024

Fix for an unnamed build stage

This change fixes a small bug that caused the Ubuntu 20.04 build to fail because the first build stage was unnamed, while the changes in #34 expected it to be named "base."

@Eta0 Eta0 added the bug Something isn't working label Apr 8, 2024
@Eta0 Eta0 self-assigned this Apr 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

@Eta0 Build complete, success: https://github.com/coreweave/nccl-tests/actions/runs/8608043805
Image: ghcr.io/coreweave/nccl-tests:12.0.1-cudnn8-devel-ubuntu20.04-nccl2.19.3-1-6f3de3e

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

@Eta0 Build complete, success: https://github.com/coreweave/nccl-tests/actions/runs/8608043805
Image: ghcr.io/coreweave/nccl-tests:11.8.0-cudnn8-devel-ubuntu20.04-nccl2.16.5-1-6f3de3e

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

@Eta0 Build complete, success: https://github.com/coreweave/nccl-tests/actions/runs/8608043805
Image: ghcr.io/coreweave/nccl-tests:12.1.1-cudnn8-devel-ubuntu20.04-nccl2.18.3-1-6f3de3e

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

@Eta0 Build complete, success: https://github.com/coreweave/nccl-tests/actions/runs/8608043805
Image: ghcr.io/coreweave/nccl-tests:12.2.2-cudnn8-devel-ubuntu20.04-nccl2.21.5-1-6f3de3e

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

@Eta0 Build complete, success: https://github.com/coreweave/nccl-tests/actions/runs/8608043805
Image: ghcr.io/coreweave/nccl-tests:12.3.2-cudnn9-devel-ubuntu20.04-nccl2.20.3-1-6f3de3e

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

@Eta0 Build complete, success: https://github.com/coreweave/nccl-tests/actions/runs/8608043805
Image: ghcr.io/coreweave/nccl-tests:12.4.0-devel-ubuntu20.04-nccl2.21.5-1-6f3de3e

@Eta0 Eta0 requested a review from wbrown April 10, 2024 20:15
@Eta0 Eta0 requested a review from salanki April 25, 2024 00:51
@Eta0 Eta0 mentioned this pull request Apr 25, 2024
Merged
@wbrown wbrown closed this pull request by merging all changes into master in ba61c6a Apr 25, 2024
@Eta0 Eta0 deleted the eta/build-stage-names branch April 25, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbrown wbrown Awaiting requested review from wbrown

@salanki salanki Awaiting requested review from salanki

Assignees

@Eta0 Eta0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eta0 @wbrown