Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logs and dont fail if it is a duplicated order #40

Merged
merged 6 commits into from
Aug 16, 2023
Merged

Improve logs and dont fail if it is a duplicated order #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c905aa3
Improve logs and dont fail if it is a duplicated order
anxolin Aug 11, 2023
41ab185
Improve notifications and make them a bit less noisy
anxolin Aug 12, 2023
78fd705
Improve logs and fix slack notifications
anxolin Aug 14, 2023
aaf2d81
Correct texts
anxolin Aug 16, 2023
9879690
Correct text
anxolin Aug 16, 2023
90c7931
Correct texts
anxolin Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,6 @@ NETWORK=5 # Network to test. 1: Mainnet, 5: Goerli, 100: xDai
# NODE_USER_100=
# NODE_PASSWORD_100=

# Slack
SLACK_WEBHOOK_URL=
NOTIFICATIONS_ENABLED=false
10 changes: 8 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,6 @@ Notably, with the `CondtionalOrderCreated` and `MerkleRootSet` events, multiple

As orders expire, or are cancelled, they are removed from the registry to conserve storage space.

**TODO:** Improvements to flag an `orderUid` as `SUBMITTED` if the API returns an error due to duplicate order submission. This would limit queries to the CoW Protocol API to the total number of watchtowers being run.

### Local testing

This is asusming that you have followed the instructions for deploying the stack on `anvil` in [local deployment](#Local-deployment)
Expand All @@ -208,6 +206,14 @@ If running your own watch tower, or deploying for production:
tenderly actions deploy
```

Make sure you configure the secrets in Tenderly:

- `SLACK_WEBHOOK_URL`: Slack Webhook
- `NOTIFICATIONS_ENABLED`: (default `true`) Set to `false` to disable Slack notifications
- `NODE_URL_${network}`: RPC Node URL
- `NODE_USER_${network}`: (optional) RPC Node user name for basic auth.
- `NODE_PASSWORD_${network}`: (optional) RPC Node password name for basic auth.

## Developers

### Requirements
Expand Down
Loading