Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added note about PYTHONPATH & CYLC_PYTHONPATH #665

Merged
merged 8 commits into from
Nov 15, 2023

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Oct 17, 2023

companion to cylc/cylc-flow#5727

I've had a look at the other uses of PYTHONPATH in the docs, and I think that they are safe.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.

@wxtim wxtim requested review from oliver-sanders and MetRonnie and removed request for oliver-sanders October 17, 2023 10:34
@MetRonnie MetRonnie changed the title added note about PYTHONPATH & CYLC_PYTHONPAT added note about PYTHONPATH & CYLC_PYTHONPATH Oct 17, 2023
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
@wxtim wxtim requested a review from MetRonnie October 17, 2023 11:35
wxtim and others added 3 commits October 17, 2023 15:41
…into feature.cache_PYTHONPATH

* 'feature.cache_PYTHONPATH' of github.com:wxtim/cylc-doc:
  Update src/reference/changes.rst
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
@wxtim wxtim requested a review from MetRonnie October 17, 2023 14:45
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
@wxtim wxtim requested a review from MetRonnie October 18, 2023 09:31
@oliver-sanders oliver-sanders added this to the 8.3.0 milestone Nov 2, 2023
@MetRonnie
Copy link
Member

@wxtim Still awaiting #665 (comment)

@wxtim
Copy link
Member Author

wxtim commented Nov 7, 2023

@wxtim Still awaiting #665 (comment)

I've responded to that. Resolve if you are happy.

@MetRonnie
Copy link
Member

Not happy until the tests are happy!

src/reference/changes.rst Outdated Show resolved Hide resolved
@oliver-sanders oliver-sanders merged commit 83d8b53 into cylc:master Nov 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants