Fix base URL #13
Merged
Fix base URL #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles updated (1)
Unchanged files (1)
Total files change +409B +0.05% Final result: ✅ View report in BundleMon website ➡️ |
|
Thanks for the upgrade PR but also this bug fix. I've used the vite proxy feature internally, I don't know why I did not do it here. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the problem mentioned in #12 (comment) by applying the workaround from disneystreaming/smithy4s#1245 (comment).
In addition, to avoid having to deal with multiple origins, I made the base URL start with
/apifor local development, and requests to that path will be proxied by Vite to the local backend. This removes the need to handle CORS.