Migrate tenant upgrades to data plane #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pablodanswer
force-pushed
the
migrate_tenant_upgrades_to_data_plane
branch
from
4eedac7
to
20d2301
Compare
yuhongsun96
reviewed
Nov 5, 2024
| from danswer.db.users import get_user_by_email | ||
| from danswer.utils.logger import setup_logger | ||
| from danswer.utils.telemetry import optional_telemetry | ||
| from danswer.utils.telemetry import RecordType | ||
| from danswer.utils.variable_functionality import fetch_versioned_implementation | ||
| from ee.danswer.server.tenants.provisioning import get_or_create_tenant_id |
There was a problem hiding this comment.
No ee imports outside of ee folder
yuhongsun96
approved these changes
Nov 5, 2024
| @@ -359,7 +359,7 @@ def stream_generator() -> Generator[str, None, None]: | |||
| yield json.dumps(packet) if isinstance(packet, dict) else packet | |||
|
|
|||
| except Exception as e: | |||
| logger.exception(f"Error in chat message streaming: {e}") | |||
| logger.exception("Error in chat message streaming") | |||
There was a problem hiding this comment.
Why are we changing this?
| except Exception as e: | ||
| logger.exception(f"Unexpected error updating tenant tasks: {str(e)}") | ||
| except (AttributeError, KeyError): | ||
| logger.exception("Failed to process task configuration") |
There was a problem hiding this comment.
Why do we not want these?
pablodanswer
force-pushed
the
migrate_tenant_upgrades_to_data_plane
branch
from
cbf577c
to
2ef3793
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, we had a separate url/web server for users to provision tenants. This merges the functionality into the data plane
General approach