-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate tenant upgrades to data plane #3051
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7ef0bc7
add provisioning on data plane
pablodanswer 91f92aa
functional but scrappy
pablodanswer 37349c9
minor cleanup
pablodanswer 2f34c59
minor clean up
pablodanswer 1dc80d6
k
pablodanswer 3f2951c
simplify
pablodanswer d52e353
update provisioning
pablodanswer 849f4c6
improve import logic
pablodanswer 0f08e36
ensure proper conditional
pablodanswer af88f7e
minor pydantic update
pablodanswer 2ec3b44
minor config update
pablodanswer 2ef3793
nit
pablodanswer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -119,10 +119,10 @@ def _update_tenant_tasks(self) -> None: | |
else: | ||
logger.info("Schedule is up to date, no changes needed") | ||
|
||
except (AttributeError, KeyError) as e: | ||
logger.exception(f"Failed to process task configuration: {str(e)}") | ||
except Exception as e: | ||
logger.exception(f"Unexpected error updating tenant tasks: {str(e)}") | ||
except (AttributeError, KeyError): | ||
logger.exception("Failed to process task configuration") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we not want these? |
||
except Exception: | ||
logger.exception("Unexpected error updating tenant tasks") | ||
|
||
def _should_update_schedule( | ||
self, current_schedule: dict, new_schedule: dict | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -359,7 +359,7 @@ def stream_generator() -> Generator[str, None, None]: | |
yield json.dumps(packet) if isinstance(packet, dict) else packet | ||
|
||
except Exception as e: | ||
logger.exception(f"Error in chat message streaming: {e}") | ||
logger.exception("Error in chat message streaming") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why are we changing this? |
||
yield json.dumps({"error": str(e)}) | ||
|
||
finally: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No ee imports outside of ee folder