Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-13785 gurt: protect d_log_refcount with d_log_lock #12467

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

kccain
Copy link
Contributor

@kccain kccain commented Jun 21, 2023

Coverity fix for CID 1443180

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Coverity fix for CID 1443180

Required-githooks: true

Signed-off-by: Kenneth Cain <kenneth.c.cain@intel.com>
@github-actions
Copy link

github-actions bot commented Jun 21, 2023

Bug-tracker data:
Ticket title is '[coverity] 1443180 Data race condition'
Status is 'In Progress'
Labels: 'coverity,required_for_code_freeze'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-13785

@github-actions github-actions bot added priority Ticket has high priority (automatically managed) release-2.4 PR is eventually targeted for 2.4 labels Jun 21, 2023
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-12467/1/testReport/

@kccain
Copy link
Contributor Author

kccain commented Jun 21, 2023

Unit Test on EL 8 failure (src-control-run_go_tests.sh) appears to be an instance of https://daosio.atlassian.net/browse/DAOS-13765
(that is marked as a duplicate of this work in progress ticket https://daosio.atlassian.net/browse/DAOS-13771)

Rerunning the testing from the unit test stage in Jenkins to hopefully move beyond the intermittent failure and make the PR land-able

@kccain kccain marked this pull request as ready for review June 21, 2023 18:54
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12467/2/execution/node/1047/log

@kccain
Copy link
Contributor Author

kccain commented Jun 23, 2023

Build 2 functional hardware medium test failures all show repeated -DER_TIMEDOUT seen during execution of a pool create command, and seem to be instances of the existing bugs https://daosio.atlassian.net/browse/DAOS-13570 (duplicate of https://daosio.atlassian.net/browse/DAOS-13678).

https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12467/2/testReport/junit/FTEST_aggregation/DaosAggregationBasic/Test_Hardware___Functional_Hardware_Medium___1___aggregation_basic_py_DaosAggregationBasic_test_basic_aggregation_run_container_hosts_ior_client_processes_iorflags_objectclass_oclass_SX_pool_server_config_engines_0_storage_0_1_80f1/

https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12467/2/testReport/junit/FTEST_aggregation/DaosAggregationBasic/Test_Hardware___Functional_Hardware_Medium___2___aggregation_basic_py_DaosAggregationBasic_test_basic_aggregation_run_container_hosts_ior_client_processes_iorflags_objectclass_oclass_RP_2GX_pool_server_config_engines_0_storage_0_1_a4f3/

https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12467/2/testReport/junit/FTEST_aggregation/AggregationChecksum/Test_Hardware___Functional_Hardware_Medium___1___aggregation_checksum_py_AggregationChecksum_test_aggregationchecksum_run_container_hosts_ior_client_processes_objectclass_SX_transfersize_blocksize_2K_pool_server_config_engines_0_storage_0_1_b17c/

https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12467/2/testReport/junit/FTEST_pool/PoolCreateTests/Test_Hardware___Functional_Hardware_Medium___1___pool_create_py_PoolCreateTests_test_create_no_space_loop_run_hosts_pool_1_pool_2_server_config_engines_0_storage_0_1_timeouts_ec9e/

@kccain kccain added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jun 23, 2023
@kccain kccain requested a review from a team June 23, 2023 14:02
@kccain
Copy link
Contributor Author

kccain commented Jun 23, 2023

requesting force landing given the nature of this code change, the unrelated test failures, and negative impact of tying up hw clusters to rerun tests with intermittent failures.

@mchaarawi mchaarawi merged commit dc5bbd4 into master Jun 23, 2023
20 checks passed
@mchaarawi mchaarawi deleted the kccain/cid_1443180 branch June 23, 2023 14:05
kccain added a commit that referenced this pull request Jun 23, 2023
Coverity fix for CID 1443180

Signed-off-by: Kenneth Cain <kenneth.c.cain@intel.com>
mchaarawi pushed a commit that referenced this pull request Jun 23, 2023
)

Coverity fix for CID 1443180

Signed-off-by: Kenneth Cain <kenneth.c.cain@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed) release-2.4 PR is eventually targeted for 2.4
Development

Successfully merging this pull request may close these issues.

4 participants