Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-13471 control: Add structured version info to utilities #12544

Merged
merged 2 commits into from
Jul 19, 2023
Merged

DAOS-13471 control: Add structured version info to utilities #12544

merged 2 commits into from
Jul 19, 2023

Conversation

mjmac
Copy link
Contributor

@mjmac mjmac commented Jun 27, 2023 •
edited
Loading

Allow consumers to grab structured build/version information.
Centralizes JSON output logic to a single implementation in
the cmdutil package. Includes updates to control/version.py
to use the structured version information instead of scraping
stdout. Includes changes made for DAOS-13236 to include
build info in version output and DAOS-13878 to install
golang >= 1.18 as a daos-tests dependency.

Signed-off-by: Michael MacDonald mjmac.macdonald@intel.com

@mjmac mjmac requested review from a team as code owners June 27, 2023 19:31
@github-actions
Copy link

github-actions bot commented Jun 27, 2023 •
edited
Loading

Bug-tracker data:
Ticket title is 'Consistent way to get only the version number from any DAOS binary'
Status is 'Awaiting backport'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-13471

daosbuild1
daosbuild1 reviewed Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

daltonbohning
daltonbohning reviewed Jun 27, 2023
View reviewed changes
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftest LGTM

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-12544/1/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12544/1/execution/node/1241/log

daosbuild1
daosbuild1 reviewed Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12544/3/execution/node/1315/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12544/4/execution/node/328/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12544/5/execution/node/328/log

@mjmac
DAOS-13471 control: Add structured version info to utilities
3fbd6d7 
Allow consumers to grab structured build/version information.
Centralizes JSON output logic to a single implementation in
the cmdutil package. Includes updates to control/version.py
to use the structured version information instead of scraping
stdout. Includes changes made for DAOS-13236 to include
build info in version output and DAOS-13878 to install
golang >= 1.18 as a daos-tests dependency.

Required-githooks: true

Signed-off-by: Michael MacDonald <mjmac.macdonald@intel.com>
@mjmac mjmac requested a review from a team as a code owner July 2, 2023 21:42
daosbuild1
daosbuild1 reviewed Jul 2, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12544/6/execution/node/1270/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12544/6/execution/node/1286/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12544/7/execution/node/365/log

@mjmac mjmac requested review from kjacque and knard-intel July 4, 2023 19:10
kjacque
kjacque previously approved these changes Jul 5, 2023
View reviewed changes
knard-intel
knard-intel previously approved these changes Jul 6, 2023
View reviewed changes
@kjacque kjacque requested a review from a team July 12, 2023 20:51
@daltonbohning
Copy link
Contributor

PR now has conflicts in

debian/changelog
utils/rpms/daos.spec

@knard-intel knard-intel mentioned this pull request Jul 17, 2023
Merged
18 tasks
@mjmac
Required-githooks: true
71a5bd8 
Merge branch 'release/2.4' into mjmac/DAOS-13236-13471
@mjmac mjmac dismissed stale reviews from knard-intel and kjacque via 71a5bd8 July 17, 2023 21:00
@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Jul 17, 2023
daosbuild1
daosbuild1 reviewed Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12544/9/execution/node/1241/log

@mjmac mjmac added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jul 18, 2023
@mjmac
Copy link
Contributor Author

mjmac commented Jul 18, 2023

@daos-stack/daos-gatekeeper (cc: @kjacque): I can't check the hw-medium failure, but I'm assuming it's the usual intermittent stuff. If so, please land this ASAP because it's been ready for weeks and will allow @knard-intel's fix for DAOS-13886 to land.

@knard-intel
Copy link
Contributor

@mjmac and @daos-stack/daos-gatekeeper , the CI failure is a known issue:

@mchaarawi mchaarawi merged commit 460be98 into release/2.4 Jul 19, 2023
15 checks passed
@mchaarawi mchaarawi deleted the mjmac/DAOS-13236-13471 branch July 19, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning left review comments

@daosbuild1 daosbuild1 daosbuild1 left review comments

@kjacque kjacque kjacque approved these changes

@knard-intel knard-intel knard-intel approved these changes

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mjmac @daosbuild1 @daltonbohning @knard-intel @kjacque @mchaarawi