Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create resources in API v2, part 1 #999

Merged
merged 16 commits into from
Oct 4, 2018
Merged

Create resources in API v2, part 1 #999

merged 16 commits into from
Oct 4, 2018

Conversation

benjamingeer
Copy link

@benjamingeer benjamingeer commented Sep 25, 2018 •
edited
Loading

  • Create a new resource with values (no file values yet).
  • Fix the property knora-api:textValueHasMapping so its object is a JSON-LD object containing @id (also needs to be fixed in Knora-ui)
  • Add tests.
    • Change resources route R2R test to an E2E test.
  • Add docs.

For future PRs:

  • Create resources with file values (depends on Create/update file values in API v2 #998).
  • Update resource metadata.
  • Mark resources as deleted.
  • Implement API v2 bulk import (the design here tries to allow for this in a less complicated way than in v1).

Benjamin Geer added 12 commits September 25, 2018 10:29
feature (api-v2): Start adding plumbing for creating resources.
1bea158
feature (api-v2): Generate SPARQL for creating multiple values in a n…
7eca1b8 
…ew resource (ongoing)
feature (api-v2): Generate SPARQ L for creating values in a new resou…
d4f9098 
…rce (ongoing).
refactor (api-v2): Move some responsibility to the resources responder.
748a691
feature (api-v2): Create a resource (ongoing).
fdb6a58
feature (api-v2): Create a resource (ongoing).
ecf5407
feature (api-v2): Create a resource (ongoing).
b6be7e6
feature (api-v2): Create a resource (ongoing).
9a93fe0
feature (api-v2): Create a resource (ongoing).
3ab857a
style (api-v2): Fix typo.
e08d5e2
test (api-v2): Test creating resources without values.
5511e8d 
- Make ontology responder more tolerant of different schemas in requests.
test (api-v2): Test creating resources.
cff9da0 
- Add responder tests.
- Add e2e test.
- Fix silliness from previous commit in ontology responder.
@flavens
Copy link
Contributor

flavens commented Oct 3, 2018

Fixes have been done in Knora-ui - PR #87
Review requested before merging.

@flavens flavens mentioned this pull request Oct 3, 2018
Merged
4 tasks
@benjamingeer benjamingeer requested a review from subotic October 3, 2018 15:42
@benjamingeer benjamingeer added enhancement improve existing code or new feature ready-for-review labels Oct 3, 2018
@benjamingeer benjamingeer mentioned this pull request Oct 3, 2018
Open
subotic
subotic approved these changes Oct 4, 2018
View reviewed changes
Copy link
Collaborator

@subotic subotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, LGTM :-)

docs/src/paradox/03-apis/api-v2/editing-resources.md
@ref:[complex API schema](introduction.md#api-schema), specifying the resource's IRI, type,
and `rdfs:label`, along with its Knora resource properties and their values. The representation of the
resource is the same as when it is returned in a `GET` request, except that its IRI and
`knora-api:attachedToUser`, and those of its values, are not given. The format of the values submitted
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

, and those of its values,

unnecessary?

@benjamingeer
Copy link
Author

@subotic Thank you!

@benjamingeer benjamingeer merged commit d019b6c into develop Oct 4, 2018
@benjamingeer benjamingeer deleted the wip/v2-create-resources-1 branch October 4, 2018 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subotic subotic subotic approved these changes

Assignees
No one assigned
Labels
API/V2 enhancement improve existing code or new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjamingeer @flavens @subotic