Core module: update textValueHasMapping

[flavens]

textValueHasMapping is not a string anymore, but an object

"knora-api:textValueHasMapping" : {
    "@id" : "http://rdfh.ch/standoff/mappings/StandardMapping"
 }

Files to update:

• projects/knora/core/src/lib/declarations/api/knora-constants.ts
• projects/knora/core/src/lib/services/v2/convert-jsonld.ts
• projects/knora/core/src/lib/test-data/resources/Testthing.json
• projects/knora/core/src/lib/test-data/resources/SearchForHolzschnitt.json

[flavens]

cf Knora PR#999

[flavens]

review PR

[benjamingeer]

@kilchenmann @tobiasschweizer Could somebody please review this PR?

[kilchenmann]

We have to know, which Knora version is now required for these changes? Can someone add this information to the README of the module!?

[benjamingeer]

It will be Knora 2.0.1 (not released yet).

[kilchenmann]

great! thanks. I will add it to the README before merging

[kilchenmann]

add knora version to the readme (or somewhere). We have to do that for now on...

[benjamingeer]

I have just noticed another JSON-LD string that should be an object:

"knora-api:fileValueAsUrl" : "http://localhost:1024/knora/incunabula_0000004159.jp2/full/3625,5251/0/default.jpg"

should be

"knora-api:fileValueAsUrl" : {
  "@type" : "xsd:anyURI",
  "@value" : "http://localhost:1024/knora/incunabula_0000004159.jp2/full/3625,5251/0/default.jpg"
}

[benjamingeer]

And another one: knora-api:stillImageFileValueHasIIIFBaseUrl.

[benjamingeer]

@tobiasschweizer I think I've changed the code here to accept JSON objects in knora-api:fileValueAsUrl and knora-api:stillImageFileValueHasIIIFBaseUrl, as produced by dasch-swiss/dsp-api#1011. Could you please check whether this works?

[tobiasschweizer]

Alternative way to filter out preview images from file values:

filterOutPreviewImages(fileValue: ReadStillImageFileValue) {
        const isPreview: boolean = fileValue.imageFilename.indexOf('.jpg') !== -1;
        return !isPreview;
    }

This method can be passed to filter when applied to a collection of file values:

const fileValues: ReadStillImageFileValue[] = ...
fileValues.filter(filterOutPreviewImages);

[tobiasschweizer]

@benjamingeer I think I found a good solution to determine whether a file value is a preview or not by looking at the file extension (
a055a82)

I will now add more test for JSON-LD conversion.

[tobiasschweizer]

@benjamingeer Ok, I added more test for StillImageRepresentation with image file values and TextRepresentation with text file values.

Determining whether an image is a preview or not is now handled without fileValueIsPreview. The assumption is that previews are JPEGS.

[tobiasschweizer]

I think the ontology test data has to be adapted too

[tobiasschweizer]

@kilchenmann added required Knora version in
71b8dd8

resolved in 71b8dd8