Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix Dependabot prefix #251

Merged
merged 3 commits into from
Sep 27, 2024
Merged

chore: fix Dependabot prefix #251

merged 3 commits into from
Sep 27, 2024

Conversation

mpro7
Copy link
Contributor

@mpro7 mpro7 commented Sep 24, 2024

No description provided.

@mpro7 mpro7 self-assigned this Sep 24, 2024
@mpro7 mpro7 changed the title chore: fix dependabot prefix & increase updates interval chore: fix Dependabot prefix & increase updates interval Sep 24, 2024
Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure it's a good idea to do dependency updates so infrequently?

@@ -23,9 +23,9 @@ updates:
- package-ecosystem: "cargo"
directory: "/"
schedule:
interval: "weekly"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your title says increasing the interval, you have done the opposite.

IMHO we should keep the current schedule, is there any reason to change it?

Copy link
Contributor Author

@mpro7 mpro7 Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed I made the mistake in the title (corrected, thanks!).
We have talked about it with @BalduinLandolt last week. The current state of this service/app is kind of static/simple - no authentication, no user profile, no fragile data etc. Therefore IMO it does not make sense for more frequent dependency updates. Especially if the new version is most probably going to be released on demand only and looking back, it was even less frequent than once per month.
Once we see there is necessity for the interval increasement, it could be done.
On top of that it is impossible to customize grouped PR title created by Dependabot, which will make confusion in the release notes. Which IMO is fine, until one would need to find out in which release specific dependency was bumped. Probably not common case, but still something to keep in mind.

Copy link
Contributor

@seakayone seakayone Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your "reasons" do not convince me. I think merging some small PR every other week is not a problem.
That way we have the latests updates once we release on demand much quicker, which I deem to be more important.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is simply because my "reasons" are REASONS when you try to use them.

@mpro7 mpro7 changed the title chore: fix Dependabot prefix & increase updates interval chore: fix Dependabot prefix & decrease updates interval Sep 24, 2024
@mpro7 mpro7 changed the title chore: fix Dependabot prefix & decrease updates interval chore: fix Dependabot prefix Sep 27, 2024
@seakayone seakayone merged commit 9783e60 into main Sep 27, 2024
19 checks passed
@seakayone seakayone deleted the mpro7-patch-1 branch September 27, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants