Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix Dependabot prefix #251

Merged
merged 3 commits into from
Sep 27, 2024
Merged

chore: fix Dependabot prefix #251

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
916fb77
Update dependabot.yml
mpro7 Sep 24, 2024
d6218e3
Update dependabot.yml
mpro7 Sep 27, 2024
1f53915
Merge branch 'main' into mpro7-patch-1
mpro7 Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ updates:
schedule:
interval: "weekly"
commit-message:
prefix: "build(deps)"
prefix: "build"
include: "scope"
groups:
frontend-dependencies:
Expand All @@ -23,7 +23,7 @@ updates:
schedule:
interval: "weekly"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your title says increasing the interval, you have done the opposite.

IMHO we should keep the current schedule, is there any reason to change it?

Copy link
Contributor Author

@mpro7 mpro7 Sep 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed I made the mistake in the title (corrected, thanks!).
We have talked about it with @BalduinLandolt last week. The current state of this service/app is kind of static/simple - no authentication, no user profile, no fragile data etc. Therefore IMO it does not make sense for more frequent dependency updates. Especially if the new version is most probably going to be released on demand only and looking back, it was even less frequent than once per month.
Once we see there is necessity for the interval increasement, it could be done.
On top of that it is impossible to customize grouped PR title created by Dependabot, which will make confusion in the release notes. Which IMO is fine, until one would need to find out in which release specific dependency was bumped. Probably not common case, but still something to keep in mind.

Copy link
Contributor

@seakayone seakayone Sep 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your "reasons" do not convince me. I think merging some small PR every other week is not a problem.
That way we have the latests updates once we release on demand much quicker, which I deem to be more important.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is simply because my "reasons" are REASONS when you try to use them.

commit-message:
prefix: "build(deps)"
prefix: "build"
include: "scope"
groups:
backend-dependencies:
Expand Down