Add schema utility functions #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes 'name' from the list of required fields of the dataset schema and adds 'metadata_sources' to the list of required fields of both the dataset and file schemas
This adds the 'schema_utils' module that provides functionality for: - getting an empty dict with the exact structure of one of the schemas of a catalog (specific to a catalog or to the package itself) - getting a valid metadata item of type 'file' or 'dataset' with the minimum required fields, and populating these fields via arguments
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
==========================================
+ Coverage 86.19% 86.22% +0.02%
==========================================
Files 43 45 +2
Lines 2709 2794 +85
==========================================
+ Hits 2335 2409 +74
- Misses 374 385 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
namefrom the list of required fields of thedatasetschemaand adding
metadata_sourcesto the list of required fields of both thedatasetandfileschemasnameshould not be a required field in thedatasetschema #376metadata_sourcesshould be a required property for metadata items of typedatasetandfile#377schema_utilsmodule.