Knitting threads: bringing changes from all over into upstream #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he description field
Apart from this main addition, the commit also contains the removal of outdated rendering of the object-structure of the description field
…jects, as a test case for the funding rendering upgrade
This includes a change to the schema to define the structure of incoming metadata related to custom notebooks, and several changes to the javascript functionality. Additionally, some debugging calls are introduced to allow browser inspection- based debugging at log-level 'verbose'.
…n' button to show
✅ Deploy Preview for datalad-catalog canceled.
|
If the dataset.url exists, it should show, OR if the dataset metadata has a notebook supplied. Otherwise not. The URL field on the dataset is datalad-specific, which can be cloned via the generic notebook that is opened with binder in that case
This was referenced Apr 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is all about updating catalog assets / templates / schemas to get this repo's main branch up to speed with enhancements and bug fixes that have been applied in different catalog instances, mainly SFB1451 and ABCD-J. It includes:
descriptionfield, and updates JS/HTML to remove the outdated tags for description-type that were displayed on top of the description text and allows selecting different descriptions. If the description field is an array, descriptions are now just displayed underneath each other in sequential order (closes Update demo data and code to be consistent with newly generated catalogs #392)c475969b-2919-57b1-a3e6-71770acaa222/0.1.0)urlfield OR a populatednotebooksfield.verbose, which makes the previous use of manyconsole.logcalls unnecessary.View on GINbutton to show. Closes Discrepancy between URL field being an array and/or string #424dataset_options["include_access_request"]that should be set totrue | false. Closes Request data access button should not be shown for public dataset #427