-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[state:modified] store unrendered_database and unrendered_schema on source definition for state:modified comparisons #10675
Conversation
…ct if unavailable
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10675 +/- ##
==========================================
+ Coverage 89.15% 89.17% +0.01%
==========================================
Files 183 183
Lines 23344 23380 +36
==========================================
+ Hits 20812 20848 +36
Misses 2532 2532
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Associated schemas.getdbt.com PR: dbt-labs/schemas.getdbt.com#63 |
Sorry about the messy commit history, I think it's a GH issue from when the base was changed from #10487 to main. The changed files and contents all look correct though. |
Resolves #9573
Problem
source definitions in schema yaml files often include jinja in the
database
andschema
properties.However, this makes them sensitive to environment in that the env var/var/jinja resolution may change between runs without the actual source changing, leading to false positives.
Solution
Start persisting unrendered_database and unrendered_schema during source parsing, and do comparison on unrendered values during state:modified, behind
state_modified_compare_more_unrendered_values
behaviour flag.Checklist