-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error message when trying to select a disabled model #9863
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9863 +/- ##
==========================================
- Coverage 88.12% 88.09% -0.04%
==========================================
Files 178 178
Lines 22459 22457 -2
==========================================
- Hits 19793 19783 -10
- Misses 2666 2674 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SamuelBFavarin thanks so much for making this message more clear for everyone! Really appreciate it. There's just one issue with the changelog yaml file. Once you fix that we should be able to get this change merged in!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks so much for the quality of life improvement @SamuelBFavarin!
resolves #9747
Problem
When you run a disabled model you get this error message, that it's not so clear.
Solution
After @graciegoheen, @dataders and @dbeatty10 discussion, they agreed with this log output:
Checklist