Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message when trying to select a disabled model #9863

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

SamuelBFavarin
Copy link
Contributor

resolves #9747

Problem

When you run a disabled model you get this error message, that it's not so clear.

21:53:02  The selection criterion 'log__user_table' does not match any nodes

Solution

After @graciegoheen, @dataders and @dbeatty10 discussion, they agreed with this log output:

21:53:02  The selection criterion 'log__user_table' does not match any enabled nodes

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@SamuelBFavarin SamuelBFavarin requested a review from a team as a code owner April 5, 2024 15:53
@cla-bot cla-bot bot added the cla:yes label Apr 5, 2024
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@github-actions github-actions bot added the community This PR is from a community member label Apr 5, 2024
@SamuelBFavarin SamuelBFavarin changed the title feat: update log message Update Log Message Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.09%. Comparing base (a994ace) to head (45324e4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9863      +/-   ##
==========================================
- Coverage   88.12%   88.09%   -0.04%     
==========================================
  Files         178      178              
  Lines       22459    22457       -2     
==========================================
- Hits        19793    19783      -10     
- Misses       2666     2674       +8     
Flag Coverage Δ
integration 85.45% <100.00%> (-0.13%) ⬇️
unit 61.90% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@graciegoheen graciegoheen added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Apr 5, 2024
@graciegoheen graciegoheen self-assigned this Apr 5, 2024
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamuelBFavarin thanks so much for making this message more clear for everyone! Really appreciate it. There's just one issue with the changelog yaml file. Once you fix that we should be able to get this change merged in!

.changes/unreleased/Features-20240405-175733.yaml Outdated Show resolved Hide resolved
@dbeatty10 dbeatty10 requested a review from emmyoop April 5, 2024 18:42
@dbeatty10 dbeatty10 changed the title Update Log Message Better error message when trying to select a disabled model Apr 5, 2024
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks so much for the quality of life improvement @SamuelBFavarin!

@emmyoop emmyoop merged commit 1e4e15c into dbt-labs:main Apr 9, 2024
56 checks passed
@dbeatty10 dbeatty10 mentioned this pull request Apr 24, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] better error message when running disabled model
4 participants