Add docstrings to R Client #4363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpeters1208
added
NoDocumentationNeeded
NoReleaseNotesNeeded
chipkent
requested changes
Sep 6, 2023
# Conflicts: # R/rdeephaven/R/client_wrapper.R
# Conflicts: # R/rdeephaven/src/client.cpp
# Conflicts: # R/rdeephaven/DESCRIPTION
chipkent
requested changes
Sep 13, 2023
# Conflicts: # R/rdeephaven/R/aggregate_wrapper.R # R/rdeephaven/R/table_handle_wrapper.R
chipkent
requested changes
Sep 13, 2023
chipkent
previously requested changes
Sep 15, 2023
Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
rcaudy
approved these changes
Sep 15, 2023
rcaudy
dismissed
chipkent’s stale review
Dismissing for now to ensure we can merge something. Alex will follow up next week.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once these are reviewed, I will use them to create custom .Rd pages that are accessible via ?. Cross-join is not documented, as it is not documented in the Python API, not available in the Python API, and our cross-join does not behave how I would expect, so I don't know what to do about that.