fix: Include column name in exception when ColumnSource.cast fails #6078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbasralian
added
NoDocumentationNeeded
NoReleaseNotesNeeded
rbasralian
changed the title
rcaudy
requested changes
Sep 18, 2024
Comment on lines
111
to
117
| try { | ||
| // noinspection unchecked | ||
| return rawColumnSource.cast(clazz, componentType); | ||
| } catch (ClassCastException ex) { | ||
| throw new RuntimeException( | ||
| "Error retrieving ColumnSource with type " + clazz.getName() + " for column " + sourceName, ex); | ||
| } |
There was a problem hiding this comment.
That’s not better, or precise enough.
- No throwing RTEs. Throw something more specific.
- You should make it clearer that you’re throwing an exception because of a type mismatch. You would have failed before for a missing column.
- I think the existing error messaging is clearer and more specific.
There was a problem hiding this comment.
A better change would just be to add an optional "name" prefix to ColumnSource.cast, so the existing exceptions could refer to "ColumnSource ".
rcaudy
approved these changes
Sep 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.