Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Include column name in exception when ColumnSource.cast fails #6078

Merged
merged 5 commits into from
Sep 19, 2024
Merged

fix: Include column name in exception when ColumnSource.cast fails #6078

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b9dafb9
Include column name in exception when ColumnSource.cast fails
rbasralian Sep 18, 2024
dc184e2
include column name in prefix for `checkCastTo` instead
rbasralian Sep 18, 2024
0739544
update example code in docs to match the method
rbasralian Sep 18, 2024
2276159
spotless
rbasralian Sep 18, 2024
8582f88
test getColumnSource/ColumnSource.cast
rbasralian Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions engine/table/src/main/java/io/deephaven/engine/table/impl/TableDefaults.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,13 @@ default <T> ColumnSource<T> getColumnSource(String sourceName, Class<? extends T
@Nullable Class<?> componentType) {
@SuppressWarnings("rawtypes")
ColumnSource rawColumnSource = getColumnSource(sourceName);
// noinspection unchecked
return rawColumnSource.cast(clazz, componentType);
try {
// noinspection unchecked
return rawColumnSource.cast(clazz, componentType);
} catch (ClassCastException ex) {
throw new RuntimeException(
"Error retrieving ColumnSource with type " + clazz.getName() + " for column " + sourceName, ex);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s not better, or precise enough.

  1. No throwing RTEs. Throw something more specific.
  2. You should make it clearer that you’re throwing an exception because of a type mismatch. You would have failed before for a missing column.
  3. I think the existing error messaging is clearer and more specific.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better change would just be to add an optional "name" prefix to ColumnSource.cast, so the existing exceptions could refer to "ColumnSource ".

}

// -----------------------------------------------------------------------------------------------------------------
Expand Down
Loading