feat(cpp-client): Additional Cython support for LocalDate and LocalTime #6105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosak
added
NoDocumentationNeeded
NoReleaseNotesNeeded
jcferretti
approved these changes
Sep 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the methods
CreateLocalDateColumnSourceandCreateLocalTimeColumnSourcefor the benefit of Cython.Also it adds the constexpr method
IsBlittableToInt64toDateTime,LocalDate, andLocalTime. This method always returns true (and in fact will fail to compile otherwise). It is useful so that the Cython can havestatic_asserts that confirm that this is tgrue.