fix: Cherry-pick DH-17537: Fix Advanced Filter dialog not showing the values list on tree tables #2235
+42
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on tree tables (deephaven#2232) Move `isValuesTableAvailable` getter from `IrisGridTableModel` to `IrisGridTableModelTemplate` to make it availalbe in tree table model. Fixes DH-17537 in enterprise. Note, this doesn't fix the issue with Advanced Filter on tree tables in Community. JSAPI throws an exception on a `treeTable.copy` call. ``` [AdvancedFilterCreator] Unable to open values table Error: java.lang.UnsupportedOperationException: reexport at UnsupportedOperationException_0.createError (dh-core.js:1383:10) at UnsupportedOperationException_0.initializeBackingError (dh-core.js:1409:46) at UnsupportedOperationException_0.Throwable_0 (dh-core.js:1348:8) at UnsupportedOperationException_0.Exception_1 (dh-core.js:1433:18) at UnsupportedOperationException_0.RuntimeException_1 (dh-core.js:1446:18) at new UnsupportedOperationException_0 (dh-core.js:35418:25) at Object.lambda$56 (dh-core.js:24457:14) at JsTreeTable$lambda$56$Type.fetch_25 [as fetch_1] (dh-core.js:25453:10) at Object.$lambda$32_0 (dh-core.js:31972:23) at ClientTableState$lambda$32$Type.accept_90 [as accept] (dh-core.js:32707:9) at Function.onInvoke_2 (dh-core.js:5068:12) at lambda (dh-core.js:174:22) at new Promise (<anonymous>) at Object.$refetch_2 (dh-core.js:32098:13) at JsTreeTable.copy_1 [as copy] (dh-core.js:24514:16) at Proxy.valuesTable (IrisGridTableModelTemplate.ts:1519:32) at AdvancedFilterCreator.initValuesTable (AdvancedFilterCreator.tsx:212:13) ``` Filed an issue in Core: deephaven/deephaven-core#6097
vbabich
requested review from
a team and
dgodinez-dh
and removed request for
a team
dgodinez-dh
previously approved these changes
Sep 23, 2024
dgodinez-dh
approved these changes
Sep 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v0.85 #2235 +/- ##
=================================================
+ Coverage 46.61% 46.65% +0.03%
=================================================
Files 685 685
Lines 38491 38491
Branches 9776 9776
=================================================
+ Hits 17944 17958 +14
+ Misses 20537 20481 -56
- Partials 10 52 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
isValuesTableAvailablegetter fromIrisGridTableModeltoIrisGridTableModelTemplateto make it availalbe in tree table model.Fixes DH-17537 in enterprise.
Note, this doesn't fix the issue with Advanced Filter on tree tables in
Community. JSAPI throws an exception on a
treeTable.copycall.Filed an issue in Core:
deephaven/deephaven-core#6097