Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cherry-pick DH-17537: Fix Advanced Filter dialog not showing the values list on tree tables #2235

Merged

Commits on Sep 23, 2024

  1. fix: DH-17537: Fix Advanced Filter dialog not showing the values list…

    … on tree tables (deephaven#2232)
    
    Move `isValuesTableAvailable` getter from `IrisGridTableModel` to
    `IrisGridTableModelTemplate` to make it availalbe in tree table model.
    Fixes DH-17537 in enterprise.
    
    Note, this doesn't fix the issue with Advanced Filter on tree tables in
    Community. JSAPI throws an exception on a `treeTable.copy` call.
    
    ```
    [AdvancedFilterCreator] Unable to open values table Error: java.lang.UnsupportedOperationException: reexport
        at UnsupportedOperationException_0.createError (dh-core.js:1383:10)
        at UnsupportedOperationException_0.initializeBackingError (dh-core.js:1409:46)
        at UnsupportedOperationException_0.Throwable_0 (dh-core.js:1348:8)
        at UnsupportedOperationException_0.Exception_1 (dh-core.js:1433:18)
        at UnsupportedOperationException_0.RuntimeException_1 (dh-core.js:1446:18)
        at new UnsupportedOperationException_0 (dh-core.js:35418:25)
        at Object.lambda$56 (dh-core.js:24457:14)
        at JsTreeTable$lambda$56$Type.fetch_25 [as fetch_1] (dh-core.js:25453:10)
        at Object.$lambda$32_0 (dh-core.js:31972:23)
        at ClientTableState$lambda$32$Type.accept_90 [as accept] (dh-core.js:32707:9)
        at Function.onInvoke_2 (dh-core.js:5068:12)
        at lambda (dh-core.js:174:22)
        at new Promise (<anonymous>)
        at Object.$refetch_2 (dh-core.js:32098:13)
        at JsTreeTable.copy_1 [as copy] (dh-core.js:24514:16)
        at Proxy.valuesTable (IrisGridTableModelTemplate.ts:1519:32)
        at AdvancedFilterCreator.initValuesTable (AdvancedFilterCreator.tsx:212:13)
    ```
    
    Filed an issue in Core:
    deephaven/deephaven-core#6097
    vbabich committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    8a293af View commit details
    Browse the repository at this point in the history
  2. Fix unit test

    vbabich committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5b90e11 View commit details
    Browse the repository at this point in the history