Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSM Version Update #807

Merged
merged 33 commits into from
Dec 16, 2024
Merged

CSM Version Update #807

merged 33 commits into from
Dec 16, 2024

Conversation

mgandharva
Copy link
Contributor

@mgandharva mgandharva commented Dec 3, 2024 •
edited
Loading

Description

Csm version update in csm-operator for csm-1.13 release
CSM-Operator-1.8.0
CSI-PowerFlex-2.13.0
CSI-PowerMax-2.13.0
Pmax-reverse-proxy-2.12.0
CSI-PowerScale-2.13.0
CSI-PowerStore-2.13.0
CSI-Unity-2.13.0
Observabiltity-1.11.0
Karavi Topology-1.11.0
CSM Metrics PowerScale-1.8.0
CSM Metrics PowerFlex-1.11.0
CSM Metrics PowerMax-1.6.0
Replication-1.11.0
Podmon-1.12.0
App-mobility-v1.3.0
csi-metadata-retriever-1.10.0
csm-authorization-sidecar-1.13.0
dell-csi-replicator-1.11.0
dell-replication-controller-1.11.0

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1559

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • E2E "sanity with Unity Driver"
  • E2E "Install App Mobility (Standalone)"
  • E2E "Install PowerFlex Driver(Standalone)"
  • E2E "Install PowerFlex Driver (Standalone), Enable/Disable Observability"
  • E2E "Install Powerflex Driver (With Replication)"
  • E2E "Install PowerFlex Driver(With Resiliency)"
  • E2E "Install PowerMax Driver(Sidecar)"
  • E2E "Install Powermax Driver(With Resiliency), Disable Resiliency module"
  • E2E "Install Powermax Driver(Standalone), Enable Resiliency"
  • E2E "Install Powermax Driver (With Authorization v2)"
  • E2E "Install PowerStore Driver(Standalone)"
  • E2E "Install PowerScale Driver(Standalone)"
  • E2E "Install PowerScale Driver with health monitor"
  • E2E "Uninstall PowerScale Driver"
  • E2E "Observability Upgrade with Powerscale"

@mgandharva mgandharva changed the title CSM Version Update [WIP] CSM Version Update Dec 3, 2024
@mgandharva mgandharva changed the title [WIP] CSM Version Update CSM Version Update Dec 5, 2024
@mgandharva mgandharva changed the title CSM Version Update CSM Version Update [E2E is in progess do not merge] Dec 5, 2024
@mgandharva mgandharva marked this pull request as ready for review December 5, 2024 11:44
@mgandharva mgandharva requested a review from JacobGros December 10, 2024 09:47
JacobGros
JacobGros reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@JacobGros JacobGros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I'm a little confused on Auth config. Seems in some places we list "2.1.0", and in other places we use "1.3.0"- might not require any changes if I'm just behind on this topic

config/samples/storage_v1_csm_powerflex.yaml Outdated Show resolved Hide resolved
operatorconfig/moduleconfig/common/version-values.yaml Outdated Show resolved Hide resolved
@JacobGros
Copy link
Contributor

when we drop support for older versions, please make sure e2e tests are updated to not include these older versions.
I ran a pflex e2e test on this branch and saw:

 Warning  Updated  5m49s (x100 over 176m)  csm   Failed Prechecks: failed authorization proxy server validation: CSM authorization does not have v1.10.1 version. The following are supported versions: v1.11.0,v1.12.0,v1.13.0,v2.0.0,v2.0.0-alpha,v2.1.0

@mgandharva
Copy link
Contributor Author

Member

I have updated the auth, please review

@mgandharva mgandharva changed the title CSM Version Update [E2E is in progess do not merge] CSM Version Update Dec 13, 2024
@JacobGros
Copy link
Contributor

with 2.10.1 being removed, I believe this file also needs to be bumped up to 2.12:

csm-operator/tests/e2e/testfiles/storage_csm_powerflex_downgrade.yaml

Line 19 in 22e29da

configVersion: v2.10.1

@JacobGros
Copy link
Contributor

Member

I have updated the auth, please review

Looks good, were the auth2 scenarios re-ran after the update from V1 -> V2?
Iirc the scenarios for auth v2 have different steps than auth v1; so we will likely need to update scenarios.yaml if the test files were bumped from auth v1 -> v2

@JacobGros
Copy link
Contributor

JacobGros commented Dec 13, 2024 •
edited
Loading

Not related to these changes here, but since ForceUpdate was removed recently, we would also need to remove this line:

csm-operator/tests/e2e/testfiles/powerflex_alt_vals_1_values.csv

Line 7 in 22e29da

Force Update,,true,csm,1

For an e2e pass

@mgandharva
Copy link
Contributor Author

Not related to these changes here, but since ForceUpdate was removed recently, we would also need to remove this line:

csm-operator/tests/e2e/testfiles/powerflex_alt_vals_1_values.csv

Line 7 in 22e29da

Force Update,,true,csm,1

For an e2e pass

Updated and Ran E2E. It passed

@mgandharva
Copy link
Contributor Author

with 2.10.1 being removed, I believe this file also needs to be bumped up to 2.12:

csm-operator/tests/e2e/testfiles/storage_csm_powerflex_downgrade.yaml

Line 19 in 22e29da

configVersion: v2.10.1

Updated and Ran E2E. Passed.

@mgandharva
Copy link
Contributor Author

Member

I have updated the auth, please review

Looks good, were the auth2 scenarios re-ran after the update from V1 -> V2? Iirc the scenarios for auth v2 have different steps than auth v1; so we will likely need to update scenarios.yaml if the test files were bumped from auth v1 -> v2

Yes, re-ran the E2E with powermax auth2. It passed. We can have another PR for clean-up as the PR is only for version bump-up.

JacobGros
JacobGros approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@JacobGros JacobGros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since E2E is passing, LGTM

@mgandharva mgandharva merged commit 24fe72c into main Dec 16, 2024
7 checks passed
@mgandharva mgandharva deleted the mg/component-version-update branch December 16, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarishH-DELL HarishH-DELL HarishH-DELL approved these changes

@JacobGros JacobGros JacobGros approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain chimanjain is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@gilltaran gilltaran Awaiting requested review from gilltaran gilltaran is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@ashleyvjoy ashleyvjoy Awaiting requested review from ashleyvjoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mgandharva @JacobGros @atye @HarishH-DELL @ashleyvjoy @ChristianAtDell