Improve error messages when receiving a property that forms a cycle #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfed
commented
Jul 1, 2024
dfed
commented
Jul 1, 2024
| // MARK: - Set | ||
|
|
||
| extension Set { | ||
| fileprivate func removing(_ element: Element) -> Self { |
dfed
commented
Jul 1, 2024
dfed
commented
Jul 1, 2024
Comment on lines
240
to
241
| Dependency cycle detected on RootViewController! | ||
| authService: AuthService -> authService: AuthService |
There was a problem hiding this comment.
honestly this is way, way better an error message
dfed
commented
Jul 1, 2024
Comment on lines
404
to
405
| Dependency cycle detected on RootViewController! | ||
| authService: AuthService -> authService: AuthService |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
- Coverage 99.66% 99.66% -0.01%
==========================================
Files 47 47
Lines 11330 11520 +190
==========================================
+ Hits 11292 11481 +189
- Misses 38 39 +1
|
dfed
changed the title
dfed
commented
Jul 2, 2024
| @@ -80,68 +80,100 @@ final class Scope: Hashable { | |||
| propertyStack: OrderedSet<Property>, | |||
| erasedToConcreteExistential: Bool | |||
| ) throws -> ScopeGenerator { | |||
| if | |||
There was a problem hiding this comment.
Best reviewed with whitespace ignored.
The check in this if statement was moved (with changes) below under the comment // Check received children for cycles.
|
Happy to take feedback post-merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #93 and #94