feat(frontend): unify info modals #3096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loki344
added a commit
that referenced
this pull request
Oct 25, 2024
# Motivation As part of #3096 the info modals are unified. First step is to remove the about what modal. # Changes - Remove all references and usages of about what modal including tests # Tests - Removed tests for about what modal    --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
…info-modals # Conflicts: # e2e/about-why-oisy-modal.spec.ts # src/frontend/src/lib/components/core/Menu.svelte # src/frontend/src/lib/components/hero/Header.svelte # src/frontend/src/lib/components/hero/about/AboutMenu.svelte # src/frontend/src/lib/components/hero/about/AboutWhyOisy.svelte # src/frontend/src/lib/components/hero/about/AboutWhyOisyModal.svelte # src/frontend/src/lib/components/navigation/InfoMenu.svelte # src/frontend/src/lib/constants/test-ids.constants.ts # src/frontend/src/lib/derived/modal.derived.ts # src/frontend/src/lib/i18n/en.json # src/frontend/src/lib/stores/modal.store.ts # src/frontend/src/lib/types/i18n.d.ts
AntonioVentilii-DFINITY
approved these changes
Oct 25, 2024
…info-modals # Conflicts: # e2e/homepage.spec.ts-snapshots/should-display-homepage-in-logged-in-state-1-Google-Chrome-linux.png
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Instead of two separate info modals, the information is unified and improved by the suggestions of an iteration with stakeholders.
Notes
MR for removing other modal already merged:
#3097
Changes
Remove AboutHow modal
Refactor AboutWhy modal into AboutWhyOisy to include new texts