refactor(frontend): remove deprecated logged out status in Transactions #3321
+1
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterpeterparker
approved these changes
Nov 5, 2024
…out-status-in-Transactions
…out-status-in-Transactions
AntonioVentilii-DFINITY
deleted the
refactor(frontend)/remove-deprecated-logged-out-status-in-Transactions
branch
AntonioVentilii
added a commit
that referenced
this pull request
Nov 5, 2024
# Note This is a duplicate of #3332 because I changed the account # Motivation After PR #3321 , we merge the component `TransactionsSignedIn` into `Transactions`, since there is no signed-in state anymore. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The route that loads the
Transactionscomponent has currently an Authorization guard, so we will never have access to it with the user signed out.Changes
Transactionscomponent.TransactionsSignedOut