feat(frontend): add info box in activity page #3548
Conversation
yes, it is in the plans, but need to verify if it is by session or cached; this one will be provided in another PR, but not for now
Correct, this is the new info box component from the Figma library. Not really sure if the others will be modified too, to be honest, but I can ask. |
| @@ -1,18 +1,19 @@ | |||
| <script lang="ts"> | |||
| import IconInfo from '$lib/components/icons/lucide/IconInfo.svelte'; | |||
|
|
|||
| export let level: 'info' | 'light-warning' | 'error' = 'info'; | |||
| export let level: 'plain' | 'info' | 'light-warning' | 'error' = 'info'; | |||
There was a problem hiding this comment.
I don't understand "plain" in this context I have to say. 🤷♂️
Why not using "info"?
There was a problem hiding this comment.
on Figma, they have several levels for this message box, and they asked to be with white background (defined as plain) to have more contrast. The level info has a bluish background
There was a problem hiding this comment.
What I mean is "level === plain", what's a level "plain"?
But all good if it's use in Figma makes sense to use it here as well.
If you don't mind please do ask if the existing box design should be updated. Consistency is my passion 😉. Thanks! |
|
@peterpeterparker I asked @artkorotkikh-dfinity to have a look: he will probably give a direct feedback or maybe ask @StefanBerger-DFINITY to follow up on this |
AntonioVentilii
deleted the
feat(frontend)/add-info-box-in-activity-page
branch
|
I'm late! But:
|
Motivation
We include an info box in the activity page to warn about third-parties on BTC transactions.
My understanding of the requirements is that we always show it, independently of having or not BTC transactions, hence there is no logic to show it or not.