-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): add info box in activity page #3548
Merged
AntonioVentilii
merged 4 commits into
main
from
feat(frontend)/add-info-box-in-activity-page
Nov 14, 2024
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
82da98c
feat(frontend): add info box in activity page
AntonioVentilii e391915
🤖 Apply formatting changes
github-actions[bot] 1a2c336
Merge branch 'main' into feat(frontend)/add-info-box-in-activity-page
AntonioVentilii 4070880
Merge branch 'main' into feat(frontend)/add-info-box-in-activity-page
AntonioVentilii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
11 changes: 9 additions & 2 deletions
11
src/frontend/src/lib/components/transactions/AllTransactions.svelte
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,16 @@ | ||
<script lang="ts"> | ||
import AllTransactionsList from '$lib/components/transactions/AllTransactionsList.svelte'; | ||
import MessageBox from '$lib/components/ui/MessageBox.svelte'; | ||
import PageTitle from '$lib/components/ui/PageTitle.svelte'; | ||
import { i18n } from '$lib/stores/i18n.store'; | ||
</script> | ||
|
||
<PageTitle>{$i18n.activity.text.title}</PageTitle> | ||
<div class="flex flex-col gap-5"> | ||
<PageTitle>{$i18n.activity.text.title}</PageTitle> | ||
|
||
<AllTransactionsList /> | ||
<MessageBox level="plain"> | ||
{$i18n.activity.info.btc_transactions} | ||
</MessageBox> | ||
|
||
<AllTransactionsList /> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand "plain" in this context I have to say. 🤷♂️
Why not using "info"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on Figma, they have several levels for this message box, and they asked to be with white background (defined as
plain
) to have more contrast. The levelinfo
has a bluish backgroundThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I mean is "level === plain", what's a level "plain"?
But all good if it's use in Figma makes sense to use it here as well.