Consider descendents of closed details unfocusable #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knuton
force-pushed
the
dimensionless-not-focusable
branch
2 times, most recently
from
f8ca609
to
2502f8a
Compare
cypress refuses to apply focus to some elements it does not consider focusable, even though all browsers apply focus just fine.
Somewhat counterintuitively, descendents of closed details elements are seemingly not inert, invisible, dimensionless, etc. Therefore we detect them explicitly to exclude them from focusable elements.
knuton
force-pushed
the
dimensionless-not-focusable
branch
from
5060c4a
to
5342be1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat counterintuitively, descendents of closed details elements are seemingly not inert, invisible, dimensionless, etc. Therefore we have to detect them explicitly to exclude them from focusable elements.