Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider descendents of closed details unfocusable #6

Merged
merged 3 commits into from
Mar 17, 2024
Merged

Consider descendents of closed details unfocusable #6

merged 3 commits into from
Mar 17, 2024

Commits on Mar 16, 2024

  1. Use native focus 

    cypress refuses to apply focus to some elements it does not consider focusable, even though all browsers apply focus just fine.
    @knuton
    knuton committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    478a185 View commit details
    Browse the repository at this point in the history

  2. Add basic editorconfig

    @knuton
    knuton committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    b582c1d View commit details
    Browse the repository at this point in the history

  3. Consider descendents of closed details unfocusable 

    Somewhat counterintuitively, descendents of closed details elements are
seemingly not inert, invisible, dimensionless, etc. Therefore we detect
them explicitly to exclude them from focusable elements.
    @knuton
    knuton committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    5342be1 View commit details
    Browse the repository at this point in the history