Handle FunctionCallExpression #761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ This PR fixes following deprecations: Total deprecations: 110 Total warnings: 4 Build statistics: statistics (-before, +after)
client size=1048544 bin/dcd-client
server size=3085624 bin/dcd-server
rough build time=62s
-DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:07.82
-DCD run_tests.sh Maximum resident set size (kbytes): 43988
+DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:08.16
+DCD run_tests.sh Maximum resident set size (kbytes): 46920
short requests: (230x)
- min request time = 0.009ms
- 10th percentile = 0.115ms
+ min request time = 0.011ms
+ 10th percentile = 0.118ms
median time = 0.354ms
- 90th percentile = 0.591ms
- max request time = 1.456ms
+ 90th percentile = 0.615ms
+ max request time = 1.387ms
long requests over 10ms: (51x)
- min request time = 11.062ms
- 10th percentile = 11.636ms
- median time = 12.722ms
- 90th percentile = 15.549ms
- max request time = 21.478ms
+ min request time = 17.737ms
+ 10th percentile = 18.255ms
+ median time = 19.713ms
+ 90th percentile = 22.516ms
+ max request time = 30.135ms
top 5 GC sources in server:
bytes allocated, allocations, type, function, file:line
- 78101504 842 void[] std.array.Appender!(const(TokenStructure!(ubyte, "import dparse.lexer:TokenTriviaFields,TriviaToken; mixin TokenTriviaFields;"))[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.105.3/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3634
- 15257216 476788 void[] core.lifetime._d_newitemT!(Data)._d_newitemT /opt/hostedtoolcache/dc/dmd-2.105.3/x64/dmd2/linux/bin64/../../src/druntime/import/core/lifetime.d:2833
+ 78117888 844 void[] std.array.Appender!(const(TokenStructure!(ubyte, "import dparse.lexer:TokenTriviaFields,TriviaToken; mixin TokenTriviaFields;"))[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.105.3/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3634
+ 15257312 476791 void[] core.lifetime._d_newitemT!(Data)._d_newitemT /opt/hostedtoolcache/dc/dmd-2.105.3/x64/dmd2/linux/bin64/../../src/druntime/import/core/lifetime.d:2833
14316800 164422 void[] std.array.Appender!(DSymbol*[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.105.3/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3634
- 9773344 305417 Data std.array.Appender!string.Appender.this /opt/hostedtoolcache/dc/dmd-2.105.3/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3509
+ 9773376 305418 Data std.array.Appender!string.Appender.this /opt/hostedtoolcache/dc/dmd-2.105.3/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3509
7371616 281 ubyte[] msgpack.unpacker.Unpacker.InternalBuffer!().initializeBuffer ../../../.dub/packages/msgpack-d/1.0.4/msgpack-d/src/msgpack/common.d:628Full build output |
|
As a result many things in DCD needs to be reworked hmm.. |
|
I also need to handle function call expression in VariableDeclaration, what a mess.. this thing is complicated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #760
Implementing inlay hints should be trivial now, just get the symbol of the function call in the module, and check parameters, each will have its token index, display the inlay there
Need to figure out how to present the data for dcd-client