-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[main] Update dependencies from dotnet/roslyn" #82466
Revert "[main] Update dependencies from dotnet/roslyn" #82466
Conversation
cc: @jaredpar in case it's interesting to you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you keep the project file changes and the change in the trimmer analyzer? Those are general goodness.
@jkoritzinsky why keep those if the generator is referenced implicitly anyway in generators.targets? Maybe I'm missing something? |
@ViktorHofer I hope I understand your question well.
I added the references to the individual projects because the logic in If we don't add it, we could get errors like these.
The roslyn process doesn't have correct version of |
If we want to just revert the Version** bump that would be fine |
ff0bd7c
to
82a24c8
Compare
Merging to unblock PRs |
Reverts #81164
This PR caused heavy managed build regressions hitting all PR builds. See #82583 and #76454