Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CCTP withdraw and noble proto for MsgDepositForBurn #90

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

rosepuppy
Copy link
Contributor

@rosepuppy rosepuppy commented Dec 8, 2023

Created v4-client-js/scripts/generate-cctp-protos.sh for generating the noble proto needed for /circle.cctp.v1.MsgDepositForBurn, only one of the proto file is needed. it can be updated with npm run update-cctp-protos

@rosepuppy rosepuppy changed the title Support CCTP withdraw and noble burn protos Support CCTP withdraw and noble proto for MsgDepositForBurn Dec 8, 2023
Copy link
Contributor

@johnqh johnqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be in v4-chain's script so the Msg will always be up to date and available?

@johnqh johnqh self-requested a review December 11, 2023 18:40
@ruixhuang ruixhuang merged commit 28e4d4d into main Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants