Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colcon on github CI #76

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Fix colcon on github CI #76

merged 2 commits into from
Nov 30, 2023

Conversation

irenebm
Copy link
Member

@irenebm irenebm commented Nov 30, 2023

Applied solution as in: eProsima/Fast-DDS#4075

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm irenebm changed the title Install python packages and colcon using eProsima-CI Fix colcon on github CI Nov 30, 2023
@@ -235,7 +286,7 @@ jobs:
head -n 1)
echo "fastdds_job_id=${JOB_ID}" >> $GITHUB_ENV

- name: Download eProsima dependencies
- name: Download eProsima dependenciespackages

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restore this?

Suggested change
- name: Download eProsima dependenciespackages
- name: Download eProsima dependencies

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
Copy link

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irenebm irenebm merged commit 6b33623 into main Nov 30, 2023
12 checks passed
@irenebm irenebm deleted the bugfix/empy_version branch November 30, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants