Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19268] Replace uint64_t by 8 in alignas specifier #3752

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

rsanchez15
Copy link
Contributor

@rsanchez15 rsanchez15 commented Jul 27, 2023

Description

Some android build targets cannot translate from alignas(uint64_t) to alignas(8).

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15 rsanchez15 added the ci-pending PR which CI is running label Jul 31, 2023
@rsanchez15 rsanchez15 added this to the v2.12.0 milestone Jul 31, 2023
@EduPonz
Copy link

EduPonz commented Jul 31, 2023

@Mergifyio please backport 2.6.x 2.10.x 2.11.x

@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2023

please backport 2.6.x 2.10.x 2.11.x

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@EduPonz
Copy link

EduPonz commented Jul 31, 2023

@Mergifyio backport 2.6.x 2.10.x 2.11.x

@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2023

backport 2.6.x 2.10.x 2.11.x

✅ Backports have been created

@EduPonz EduPonz changed the title Replace uint64_t by 8 in alignas specifier [19268] Replace uint64_t by 8 in alignas specifier Aug 1, 2023
@EduPonz EduPonz merged commit 9ae27f1 into master Aug 1, 2023
6 of 8 checks passed
@EduPonz EduPonz deleted the feature/alignas-compatibility branch August 1, 2023 05:41
mergify bot pushed a commit that referenced this pull request Aug 1, 2023
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit 9ae27f1)
mergify bot pushed a commit that referenced this pull request Aug 1, 2023
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit 9ae27f1)
mergify bot pushed a commit that referenced this pull request Aug 1, 2023
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit 9ae27f1)
MiguelCompany pushed a commit that referenced this pull request Aug 7, 2023
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit 9ae27f1)

Co-authored-by: Raul Sanchez-Mateos Lizano <raul@eprosima.com>
EduPonz pushed a commit that referenced this pull request Aug 7, 2023
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
(cherry picked from commit 9ae27f1)

Co-authored-by: Raul Sanchez-Mateos Lizano <raul@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants