Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19268] Replace uint64_t by 8 in alignas specifier #3752

Merged
merged 1 commit into from
Aug 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cpp/rtps/DataSharing/DataSharingNotification.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ class DataSharingNotification

#pragma warning(push)
#pragma warning(disable:4324)
struct alignas (uint64_t) Notification
struct alignas (8) Notification
jsan-rt marked this conversation as resolved.
Show resolved Hide resolved
{
//! CV to wait for new notifications
Segment::condition_variable notification_cv;
Expand Down
4 changes: 2 additions & 2 deletions src/cpp/rtps/DataSharing/DataSharingPayloadPool.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ class DataSharingPayloadPool : public IPayloadPool

#pragma warning(push)
#pragma warning(disable:4324)
class alignas (uint64_t) PayloadNode
class alignas (8) PayloadNode
jsan-rt marked this conversation as resolved.
Show resolved Hide resolved
{

struct PayloadNodeMetaData
Expand Down Expand Up @@ -338,7 +338,7 @@ class DataSharingPayloadPool : public IPayloadPool

};

struct alignas (uint64_t) PoolDescriptor
struct alignas (8) PoolDescriptor
jsan-rt marked this conversation as resolved.
Show resolved Hide resolved
{
uint32_t history_size; //< Number of payloads in the history
uint64_t notified_begin; //< The index of the oldest history entry already notified (ready to read)
Expand Down
Loading