[20238] Enabling multiple interfaces through whitelist in TCP servers (backport #4297) #4414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
11 tasks
|
@cferreiragonz friendly pinging here also. |
cferreiragonz
changed the base branch from
2.6.x
to
mergify/bp/2.6.x/pr-4277
cferreiragonz
force-pushed
the
mergify/bp/2.6.x/pr-4297
branch
from
998c384
to
d59e234
Compare
|
cferreiragonz
force-pushed
the
mergify/bp/2.6.x/pr-4297
branch
from
d59e234
to
9ece5b6
Compare
cferreiragonz
force-pushed
the
mergify/bp/2.6.x/pr-4277
branch
from
88fe9f3
to
c3e6242
Compare
cferreiragonz
added
temporarily-blocked
cferreiragonz
force-pushed
the
mergify/bp/2.6.x/pr-4277
branch
from
c3e6242
to
b4acd76
Compare
|
@cferreiragonz would you mind addressing the conflicts here ? Next one in the loop ! |
* Refs #20238: Add whitelist test in TCPv4 Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20238: Add whitelist test in TCPv6 Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20238: Adding interface to locator if whitelist is not empty Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20238: Uncrustify Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20238: Fix build in Windows Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20238: Apply suggestions Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #20238: Remove repeated addition of listener port (added by default) Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 5f65a65)
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
cferreiragonz
force-pushed
the
mergify/bp/2.6.x/pr-4297
branch
from
9ece5b6
to
c98e924
Compare
|
@richiprosima please test this |
|
@richiprosima please test mac |
6 similar comments
|
@richiprosima please test mac |
|
@richiprosima please test mac |
|
@richiprosima please test mac |
|
@richiprosima please test mac |
|
@richiprosima please test mac |
|
@richiprosima please test mac |
|
Failed tests are totally unrelated to this PR, since they are not TCP related. We are not waiting for jenkins mac ci. Ready to merge |
Mario-DL
added
the
ready-to-merge
Mario-DL
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #4297 done by Mergify.
Cherry-pick of 5f65a65 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com