[20508] TCP first message loss #4454

jepemi · 2024-02-26T15:34:31Z

Description

In the initial TCP logical port negotiation some logical port requests were missing. This would not prevent communication as those remaining requests would be sent on the first data sent to that logical port. However, that data would be discarded.

With this PR all discovered logical ports are requested on initialization and the first data would not need to be discarded.

@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
New feature has been documented/Current behavior is correctly described in the documentation.
Related documentation PR: [20508] TCP first message loss Fast-DDS-docs#699
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

MiguelCompany

I made a refactor in wait_logical_port_under_negotiation (it was easier than adding suggestions)

test/blackbox/api/dds-pim/PubSubReader.hpp

test/blackbox/api/fastrtps_deprecated/PubSubReader.hpp

test/blackbox/common/BlackboxTestsTransportTCP.cpp

src/cpp/rtps/transport/TCPChannelResource.h

src/cpp/rtps/transport/TCPTransportInterface.cpp

src/cpp/rtps/transport/TCPChannelResource.h

src/cpp/rtps/transport/TCPTransportInterface.h

src/cpp/rtps/transport/tcp/RTCPMessageManager.cpp

src/cpp/rtps/xmlparser/XMLParser.cpp

MiguelCompany · 2024-03-05T11:11:28Z

@richiprosima Please test this

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

…ting purposes) Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

EduPonz · 2024-03-05T20:28:36Z

@richiprosima please test this

jepemi · 2024-03-15T07:53:38Z

@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x

mergify · 2024-03-15T07:53:46Z

backport 2.13.x 2.12.x 2.10.x 2.6.x

✅ Backports have been created

#4560 [20508] TCP first message loss (backport #4454) has been created for branch 2.13.x but encountered conflicts
#4561 [20508] TCP first message loss (backport #4454) has been created for branch 2.12.x but encountered conflicts
#4562 [20508] TCP first message loss (backport #4454) has been created for branch 2.10.x but encountered conflicts
#4563 [20508] TCP first message loss (backport #4454) has been created for branch 2.6.x but encountered conflicts

* Refs #20508: add remaining add_logical_port calls Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add blackbox test + uncomment section (commented for testing purposes) Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add blackbox tests + functional fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add cv + fix windows tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508. Use lock_guard where apropiate. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508. Proxy is_local_port_opened. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508. Refactor wait_logical_port_under_negotiation. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix typo Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add wait_for_logical_port_negotiation_ms to transport descriptor Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Apply suggestions - firs message loss related Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Apply suggestions - transport descriptor related Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Reuse unused transport descriptor tcp_negotiation_timeout Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Change timeout behavior Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix xml parser Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Undo fastcdr commit change Signed-off-by: Jesus Perez <jesusperez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 8103cf0) # Conflicts: # include/fastdds/rtps/transport/TCPTransportDescriptor.h # resources/xsd/fastRTPS_profiles.xsd # src/cpp/rtps/transport/TCPTransportInterface.cpp # src/cpp/rtps/transport/TCPTransportInterface.h # test/blackbox/common/BlackboxTestsTransportTCP.cpp # test/system/tools/xmlvalidation/XMLTesterExample_profile.xml # test/system/tools/xmlvalidation/all_profile.xml # test/unittest/transport/TCPv6Tests.cpp # test/unittest/xmlparser/XMLParserTests.cpp

* Refs #20508: add remaining add_logical_port calls Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add blackbox test + uncomment section (commented for testing purposes) Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add blackbox tests + functional fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add cv + fix windows tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508. Use lock_guard where apropiate. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508. Proxy is_local_port_opened. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508. Refactor wait_logical_port_under_negotiation. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix typo Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add wait_for_logical_port_negotiation_ms to transport descriptor Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Apply suggestions - firs message loss related Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Apply suggestions - transport descriptor related Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Reuse unused transport descriptor tcp_negotiation_timeout Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Change timeout behavior Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix xml parser Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Undo fastcdr commit change Signed-off-by: Jesus Perez <jesusperez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 8103cf0) # Conflicts: # include/fastdds/rtps/transport/TCPTransportDescriptor.h # include/fastrtps/xmlparser/XMLParserCommon.h # resources/xsd/fastRTPS_profiles.xsd # src/cpp/rtps/transport/TCPTransportInterface.cpp # src/cpp/rtps/transport/TCPTransportInterface.h # src/cpp/rtps/xmlparser/XMLParser.cpp # src/cpp/rtps/xmlparser/XMLParserCommon.cpp # test/blackbox/common/BlackboxTestsTransportTCP.cpp # test/mock/rtps/TCPTransportDescriptor/fastrtps/transport/TCPTransportDescriptor.h # test/system/tools/xmlvalidation/XMLTesterExample_profile.xml # test/system/tools/xmlvalidation/all_profile.xml # test/unittest/transport/TCPv4Tests.cpp # test/unittest/transport/TCPv6Tests.cpp # test/unittest/transport/mock/MockTCPv4Transport.h # test/unittest/transport/mock/MockTCPv6Transport.h # test/unittest/xmlparser/XMLParserTests.cpp

* Refs #20508: add remaining add_logical_port calls Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add blackbox test + uncomment section (commented for testing purposes) Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add blackbox tests + functional fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add cv + fix windows tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508. Use lock_guard where apropiate. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508. Proxy is_local_port_opened. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508. Refactor wait_logical_port_under_negotiation. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix typo Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add wait_for_logical_port_negotiation_ms to transport descriptor Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Apply suggestions - firs message loss related Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Apply suggestions - transport descriptor related Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Reuse unused transport descriptor tcp_negotiation_timeout Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Change timeout behavior Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix xml parser Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Undo fastcdr commit change Signed-off-by: Jesus Perez <jesusperez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 8103cf0) # Conflicts: # include/fastdds/rtps/transport/TCPTransportDescriptor.h # include/fastrtps/xmlparser/XMLParserCommon.h # resources/xsd/fastRTPS_profiles.xsd # src/cpp/rtps/transport/TCPTransportInterface.cpp # src/cpp/rtps/transport/TCPTransportInterface.h # src/cpp/rtps/xmlparser/XMLParser.cpp # src/cpp/rtps/xmlparser/XMLParserCommon.cpp # test/blackbox/common/BlackboxTestsTransportTCP.cpp # test/mock/rtps/TCPTransportDescriptor/fastrtps/transport/TCPTransportDescriptor.h # test/system/tools/xmlvalidation/XMLTesterExample_profile.xml # test/system/tools/xmlvalidation/all_profile.xml # test/unittest/transport/TCPv6Tests.cpp # test/unittest/xmlparser/XMLParserTests.cpp

* Refs #20508: add remaining add_logical_port calls Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add blackbox test + uncomment section (commented for testing purposes) Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add blackbox tests + functional fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add cv + fix windows tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508. Use lock_guard where apropiate. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508. Proxy is_local_port_opened. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508. Refactor wait_logical_port_under_negotiation. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix typo Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add wait_for_logical_port_negotiation_ms to transport descriptor Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Apply suggestions - firs message loss related Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Apply suggestions - transport descriptor related Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Reuse unused transport descriptor tcp_negotiation_timeout Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Change timeout behavior Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix xml parser Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Undo fastcdr commit change Signed-off-by: Jesus Perez <jesusperez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 8103cf0) # Conflicts: # include/fastdds/rtps/transport/TCPTransportDescriptor.h # include/fastrtps/xmlparser/XMLParserCommon.h # resources/xsd/fastRTPS_profiles.xsd # src/cpp/rtps/transport/TCPChannelResource.cpp # src/cpp/rtps/transport/TCPTransportInterface.cpp # src/cpp/rtps/transport/TCPTransportInterface.h # src/cpp/rtps/xmlparser/XMLParser.cpp # src/cpp/rtps/xmlparser/XMLParserCommon.cpp # test/blackbox/api/dds-pim/PubSubReader.hpp # test/blackbox/api/dds-pim/PubSubWriter.hpp # test/blackbox/api/fastrtps_deprecated/PubSubReader.hpp # test/blackbox/api/fastrtps_deprecated/PubSubWriter.hpp # test/blackbox/common/BlackboxTestsTransportTCP.cpp # test/mock/rtps/TCPTransportDescriptor/fastrtps/transport/TCPTransportDescriptor.h # test/system/tools/xmlvalidation/XMLTesterExample_profile.xml # test/system/tools/xmlvalidation/all_profile.xml # test/unittest/transport/TCPv6Tests.cpp # test/unittest/transport/mock/MockTCPv4Transport.h # test/unittest/transport/mock/MockTCPv6Transport.h # test/unittest/xmlparser/XMLParserTests.cpp

* Refs #20508: add remaining add_logical_port calls Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add blackbox test + uncomment section (commented for testing purposes) Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add blackbox tests + functional fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add cv + fix windows tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508. Use lock_guard where apropiate. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508. Proxy is_local_port_opened. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508. Refactor wait_logical_port_under_negotiation. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix typo Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add wait_for_logical_port_negotiation_ms to transport descriptor Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Apply suggestions - firs message loss related Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Apply suggestions - transport descriptor related Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Reuse unused transport descriptor tcp_negotiation_timeout Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Change timeout behavior Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix xml parser Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Undo fastcdr commit change Signed-off-by: Jesus Perez <jesusperez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit 8103cf0) # Conflicts: # include/fastdds/rtps/transport/TCPTransportDescriptor.h # resources/xsd/fastRTPS_profiles.xsd # src/cpp/rtps/transport/TCPTransportInterface.cpp # src/cpp/rtps/transport/TCPTransportInterface.h # test/blackbox/common/BlackboxTestsTransportTCP.cpp # test/system/tools/xmlvalidation/XMLTesterExample_profile.xml # test/system/tools/xmlvalidation/all_profile.xml # test/unittest/transport/TCPv6Tests.cpp # test/unittest/xmlparser/XMLParserTests.cpp

* Refs #20508: add remaining add_logical_port calls Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add unittests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add blackbox test + uncomment section (commented for testing purposes) Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add blackbox tests + functional fixes Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add cv + fix windows tests Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508. Use lock_guard where apropiate. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508. Proxy is_local_port_opened. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508. Refactor wait_logical_port_under_negotiation. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #20508: Apply suggestions Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix typo Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Add wait_for_logical_port_negotiation_ms to transport descriptor Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Apply suggestions - firs message loss related Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Apply suggestions - transport descriptor related Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Reuse unused transport descriptor tcp_negotiation_timeout Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Change timeout behavior Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Fix xml parser Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20508: Undo fastcdr commit change Signed-off-by: Jesus Perez <jesusperez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #20508: add remaining add_logical_port calls * Refs #20508: Add unittests * Refs #20508: Add blackbox test + uncomment section (commented for testing purposes) * Refs #20508: Add blackbox tests + functional fixes * Refs #20508: Fix tests * Refs #20508: Add cv + fix windows tests * Refs #20508. Use lock_guard where apropiate. * Refs #20508. Proxy is_local_port_opened. * Refs #20508. Refactor wait_logical_port_under_negotiation. * Refs #20508: Apply suggestions * Refs #20508: Fix typo * Refs #20508: Add wait_for_logical_port_negotiation_ms to transport descriptor * Refs #20508: Apply suggestions - firs message loss related * Refs #20508: Apply suggestions - transport descriptor related * Refs #20508: Reuse unused transport descriptor tcp_negotiation_timeout * Refs #20508: Change timeout behavior * Refs #20508: Uncrustify * Refs #20508: Fix xml parser * Refs #20508: Undo fastcdr commit change --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Jesús Pérez <78275223+jepemi@users.noreply.github.com> Co-authored-by: Miguel Company <miguelcompany@eprosima.com>

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

* TCP first message loss (#4454) Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs 20508: Fix xml parsing Signed-off-by: Jesus Perez <jesusperez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Co-authored-by: Jesús Pérez <78275223+jepemi@users.noreply.github.com> Co-authored-by: Jesus Perez <jesusperez@eprosima.com>

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Co-authored-by: Jesus Perez <jesusperez@eprosima.com>

EduPonz added this to the v2.14.0 milestone Feb 27, 2024

jepemi force-pushed the bugfix/tcp_first_message_loss branch from 099a560 to 0491e44 Compare February 27, 2024 09:52

jepemi added the needs-review PR that is ready to be reviewed label Feb 27, 2024

MiguelCompany requested changes Feb 28, 2024

View reviewed changes

MiguelCompany added to-do needs-review PR that is ready to be reviewed and removed needs-review PR that is ready to be reviewed to-do labels Feb 28, 2024

MiguelCompany self-requested a review February 28, 2024 16:18

MiguelCompany requested changes Feb 28, 2024

View reviewed changes

MiguelCompany added to-do and removed needs-review PR that is ready to be reviewed labels Feb 28, 2024

jepemi force-pushed the bugfix/tcp_first_message_loss branch from e71a88d to a84e916 Compare February 29, 2024 11:23

jepemi mentioned this pull request Feb 29, 2024

[20508] TCP first message loss eProsima/Fast-DDS-docs#699

Merged

7 tasks

cferreiragonz mentioned this pull request Mar 1, 2024

[20493] Extend LARGE_DATA configuration options #4444

Merged

11 tasks

jepemi force-pushed the bugfix/tcp_first_message_loss branch from b1b3264 to 0f9a863 Compare March 1, 2024 15:39

jepemi added needs-review PR that is ready to be reviewed and removed to-do labels Mar 4, 2024

MiguelCompany previously approved these changes Mar 5, 2024

View reviewed changes

MiguelCompany added ci-pending PR which CI is running and removed needs-review PR that is ready to be reviewed labels Mar 5, 2024

jepemi and others added 8 commits March 5, 2024 20:58

Refs #20508: add remaining add_logical_port calls

32d5ea4

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

Refs #20508: Add unittests

1082f3a

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

Refs #20508: Add blackbox test + uncomment section (commented for tes…

8376da5

…ting purposes) Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

Refs #20508: Add blackbox tests + functional fixes

b483602

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

Refs #20508: Fix tests

f3ea826

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

Refs #20508: Add cv + fix windows tests

e8fe131

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

Refs #20508. Use lock_guard where apropiate.

f177cce

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

Refs #20508. Proxy is_local_port_opened.

e8991ce

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

jepemi added 5 commits March 5, 2024 21:18

Refs #20508: Reuse unused transport descriptor tcp_negotiation_timeout

fa8a354

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

Refs #20508: Change timeout behavior

40cfc63

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

Refs #20508: Uncrustify

d1fd082

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

Refs #20508: Fix xml parser

3175b5d

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

Refs #20508: Undo fastcdr commit change

b470d14

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

EduPonz dismissed MiguelCompany’s stale review via b470d14 March 5, 2024 20:28

EduPonz force-pushed the bugfix/tcp_first_message_loss branch from 50a267e to b470d14 Compare March 5, 2024 20:28

EduPonz approved these changes Mar 6, 2024

View reviewed changes

EduPonz merged commit 8103cf0 into master Mar 6, 2024
13 of 17 checks passed

EduPonz deleted the bugfix/tcp_first_message_loss branch March 6, 2024 05:55

mergify bot mentioned this pull request Mar 15, 2024

[20508] TCP first message loss (backport #4454) #4560

Merged

13 tasks

mergify bot mentioned this pull request Mar 15, 2024

[20508] TCP first message loss (backport #4454) #4561

Closed

13 tasks

mergify bot mentioned this pull request Mar 15, 2024

[20508] TCP first message loss (backport #4454) #4562

Merged

13 tasks

mergify bot mentioned this pull request Mar 15, 2024

[20508] TCP first message loss (backport #4454) #4563

Merged

13 tasks

jepemi added a commit that referenced this pull request Apr 1, 2024

TCP first message loss (#4454)

bf8ad84

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

MiguelCompany pushed a commit that referenced this pull request Apr 7, 2024

TCP first message loss (#4454)

5729baa

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

jepemi added a commit that referenced this pull request Apr 8, 2024

TCP first message loss (#4454)

2a499a4

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

jepemi added a commit that referenced this pull request Apr 23, 2024

TCP first message loss (#4454)

6720de7

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>

MiguelCompany pushed a commit that referenced this pull request Apr 24, 2024

TCP first message loss (#4454) (#4563)

61bd873

Signed-off-by: Jesus Perez <jesusperez@eprosima.com> Co-authored-by: Jesus Perez <jesusperez@eprosima.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[20508] TCP first message loss #4454

[20508] TCP first message loss #4454

jepemi commented Feb 26, 2024 •

edited by EduPonz

Loading

MiguelCompany left a comment

MiguelCompany commented Mar 5, 2024

EduPonz commented Mar 5, 2024

jepemi commented Mar 15, 2024

mergify bot commented Mar 15, 2024 •

edited

Loading

[20508] TCP first message loss #4454

[20508] TCP first message loss #4454

Conversation

jepemi commented Feb 26, 2024 • edited by EduPonz Loading

Description

Contributor Checklist

Reviewer Checklist

MiguelCompany left a comment

Choose a reason for hiding this comment

MiguelCompany commented Mar 5, 2024

EduPonz commented Mar 5, 2024

jepemi commented Mar 15, 2024

mergify bot commented Mar 15, 2024 • edited Loading

✅ Backports have been created

jepemi commented Feb 26, 2024 •

edited by EduPonz

Loading

mergify bot commented Mar 15, 2024 •

edited

Loading